Namespace ApcuCache keys and scope clear() to the namespace#107
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the APCu-backed cache implementation to prefix all stored keys with a configurable namespace (default Phirewall:) and changes clear() to delete only keys within that namespace, avoiding wiping the entire shared APCu cache segment.
Changes:
- Add a
$namespaceconstructor argument toApcuCacheand prefix all APCu operations (including counter::expsidecar keys). - Scope
ApcuCache::clear()to delete only the instance namespace viaAPCUIteratorrather than callingapcu_clear_cache(). - Add unit tests covering namespacing, namespace isolation, scoped
clear(), and namespaced counter/TTL behavior; document behavior in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Store/ApcuCache.php | Namespaces all stored APCu keys and scopes clear() to only delete matching namespace entries. |
| tests/Unit/Store/ApcuCacheTest.php | Adds tests validating key namespacing, namespace isolation, scoped clearing, and namespaced counter sidecar keys. |
| CHANGELOG.md | Documents the behavioral change and migration impact of APCu key namespacing and scoped clearing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.