Stop the trusted-proxy chain walk at unparsable hops#108
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens TrustedProxyResolver’s proxy-header trust model by making the right-to-left chain walk stop and fall back to REMOTE_ADDR as soon as it encounters an unparsable hop, and updates unit tests + changelog to reflect the new semantics.
Changes:
- Treat an unparsable hop in the forwarded chain as terminal (stop walking; fall back to the direct peer).
- Update/add unit tests to assert terminal behavior for XFF and Forwarded chains.
- Document the behavioral change as a security fix in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Unit/TrustedProxyTest.php | Updates tests to cover terminal behavior for unparsable hops in XFF/Forwarded chains. |
| src/Http/TrustedProxyResolver.php | Changes resolver behavior to stop the chain walk at unparsable entries and fall back to REMOTE_ADDR. |
| CHANGELOG.md | Documents the terminal-unparsable-hop behavior as a security change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.