Skip to content

docs: wind-style relative links + marketing-first README#93

Merged
anilcancakir merged 1 commit into
masterfrom
docs/relative-links-marketing-readme
Jun 19, 2026
Merged

docs: wind-style relative links + marketing-first README#93
anilcancakir merged 1 commit into
masterfrom
docs/relative-links-marketing-readme

Conversation

@anilcancakir

Copy link
Copy Markdown
Contributor

Follow-up polish on top of #92.

What

  1. Doc links → wind convention. Magic's docs mixed two styles; wind uses repo-relative .md paths everywhere. Converted the 11 site-absolute links (/section/page) across 5 pages to relative .md (./page.md, ../section/page.md). The docs site rewrites these to its own routed URLs on sync, same as wind.
  2. README marketing-first (547 → ~190 lines), mirroring wind's shape. Minimal two-command install:
    flutter pub add magic
    dart run magic:artisan magic:install
    Lead with Why / Features (facade count corrected 17 → 18) / a compact taste; the full per-facade reference now lives in the docs. No em/en dashes (commas/colons, like wind).
  3. docs-link-check CI validates the new convention: dropped --root-dir doc / --fallback-extensions md (no more site-absolute links), and promoted --include-fragments into the per-PR offline gate so cross-page #anchors (magic's <a name> style) are validated at PR time, not just weekly.

Verification

  • lychee 0.24.2 local, new CI logic: 475 OK / 0 errors.
  • Intra-page TOC↔anchor python check unaffected (cross-page #install link has a path before #, so it is not treated as a local anchor).

- Convert the 11 site-absolute doc links (/section/page) to repo-relative
  .md paths (./page.md, ../section/page.md), matching wind's convention.
  The docs site rewrites these to its own routed URLs on sync.
- Rewrite README marketing-first like wind: minimal two-command install
  (flutter pub add magic + dart run magic:artisan magic:install), lead
  with Why/Features/taste, delegate the full reference to the docs.
- docs-link-check: drop --root-dir/--fallback-extensions (no longer any
  site-absolute links) and promote --include-fragments into the per-PR
  offline gate so cross-page #anchors are validated at PR time.
Copilot AI review requested due to automatic review settings June 19, 2026 19:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes documentation linking to Wind’s repo-relative .md convention, refactors the top-level README into a shorter marketing-first shape, and updates the docs link-check workflow to validate cross-page fragments during PRs without relying on --root-dir / --fallback-extensions.

Changes:

  • Convert remaining docs site-absolute links (e.g., /section/page) to repo-relative .md links across the touched docs pages.
  • Restructure README.md into a shorter install/why/features/example format, and update feature counts/sections accordingly.
  • Update .github/workflows/docs-link-check.yml to drop doc-root resolution flags and to validate #fragments in the per-PR offline gate.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Rewrites README into a shorter marketing-first layout; updates install snippet, features table, and doc pointers.
doc/security/encryption.md Switches Vault link to repo-relative ./vault.md.
doc/getting-started/installation.md Switches multiple “next steps” and CLI links to repo-relative .md paths (including #install fragment).
doc/digging-deeper/file-picker.md Updates Magic Storage link to ./file-storage.md.
doc/basics/routing.md Updates Middleware and Database doc links to repo-relative .md paths.
doc/basics/middleware.md Updates Authorization doc link to repo-relative ../security/authorization.md.
.github/workflows/docs-link-check.yml Removes reliance on doc-root/fallback extension flags and enables fragment validation in the PR offline link check.

Comment thread README.md
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@anilcancakir anilcancakir merged commit 2b8d33d into master Jun 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants