fix(ci): resolve pnpm version conflict and specter-roast type resolution - #83
Conversation
pnpm/action-setup@v6 errors with ERR_PNPM_BAD_PM_VERSION when both the action's version input and package.json packageManager are set (CI has been failing on every run since the packageManager pin landed). Drop the redundant version input; action-setup reads packageManager instead. packages/specter-roast build fails with TS2591/TS2584 (node: imports and console unresolved) because tsc does not auto-discover @types/node in this nested npm package. Add explicit types: ["node"] to fix.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👻 Specter Analysis
Generated by Specter - Give your codebase a voice |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are minimal, consistent with the stated failures, and align CI pnpm setup with the existing packageManager pin while fixing specter-roast TypeScript type resolution.
Pull request overview
This PR fixes ongoing CI failures caused by a pnpm version pin conflict and resolves TypeScript type resolution issues when building the nested packages/specter-roast package.
Changes:
- Removed the redundant
version: 10input frompnpm/action-setup@v6in the CI workflow so the action relies on the rootpackageManager: "pnpm@10.32.1"pin. - Updated
packages/specter-roast/tsconfig.jsonto explicitly include Node typings via"types": ["node"], fixing unresolvednode:*imports and Node globals duringtscbuilds.
File summaries
| File | Description |
|---|---|
packages/specter-roast/tsconfig.json |
Adds explicit Node type inclusion to make tsc resolve Node built-ins and globals for this package. |
.github/workflows/ci.yml |
Removes conflicting pnpm version configuration so CI can install the pnpm version pinned in package.json. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Problem
CI (
Test,Build,Security Scan) has failed on every run since thepackageManager: pnpm@10.32.1pin landed (introduced in e6f3dd1).pnpm/action-setup@v6throwsERR_PNPM_BAD_PM_VERSIONwhen both the action'sversion:input andpackage.json'spackageManagerfield are set:Separately,
packages/specter-roastfails to build (npm run build) with TS2591/TS2584 (node:fs,consoleunresolved) becausetscdoes not auto-discover@types/nodefor this nested npm package without an explicittypesarray.Both predate and are unrelated to any currently open dependency-bump PR.
Fix
version: 10input from all threepnpm/action-setup@v6steps in.github/workflows/ci.yml— the action readspackageManageron its own."types": ["node"]topackages/specter-roast/tsconfig.json.Verification
pnpm install --frozen-lockfilesucceeds (root)pnpm run build,pnpm run lint,pnpm run test:coverageall green (412/412 tests)npm run buildinpackages/specter-roastnow exits 0 (was exit 2)