Skip to content

fix(ci): resolve pnpm version conflict and specter-roast type resolution - #83

Merged
forbiddenlink merged 1 commit into
mainfrom
fix/ci-pnpm-version-conflict
Aug 26, 2026
Merged

fix(ci): resolve pnpm version conflict and specter-roast type resolution#83
forbiddenlink merged 1 commit into
mainfrom
fix/ci-pnpm-version-conflict

Conversation

@forbiddenlink

Copy link
Copy Markdown
Owner

Problem

CI (Test, Build, Security Scan) has failed on every run since the packageManager: pnpm@10.32.1 pin landed (introduced in e6f3dd1). pnpm/action-setup@v6 throws ERR_PNPM_BAD_PM_VERSION when both the action's version: input and package.json's packageManager field are set:

Error: Multiple versions of pnpm specified:
  - version 10 in the GitHub Action config with the key "version"
  - version pnpm@10.32.1 in the package.json with the key "packageManager"

Separately, packages/specter-roast fails to build (npm run build) with TS2591/TS2584 (node:fs, console unresolved) because tsc does not auto-discover @types/node for this nested npm package without an explicit types array.

Both predate and are unrelated to any currently open dependency-bump PR.

Fix

  • Drop the redundant version: 10 input from all three pnpm/action-setup@v6 steps in .github/workflows/ci.yml — the action reads packageManager on its own.
  • Add "types": ["node"] to packages/specter-roast/tsconfig.json.

Verification

  • pnpm install --frozen-lockfile succeeds (root)
  • pnpm run build, pnpm run lint, pnpm run test:coverage all green (412/412 tests)
  • npm run build in packages/specter-roast now exits 0 (was exit 2)

pnpm/action-setup@v6 errors with ERR_PNPM_BAD_PM_VERSION when both the
action's version input and package.json packageManager are set (CI has
been failing on every run since the packageManager pin landed). Drop
the redundant version input; action-setup reads packageManager instead.

packages/specter-roast build fails with TS2591/TS2584 (node: imports
and console unresolved) because tsc does not auto-discover @types/node
in this nested npm package. Add explicit types: ["node"] to fix.
Copilot AI lite review requested due to automatic review settings August 26, 2026 00:09
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ac99b51c-90ba-41e2-9cad-a795e752bd2d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

👻 Specter Analysis

Metric Value
Health Score 0/100 🔴
PR Risk Low 🟢
Files Changed -
Est. Review Time ~5 min

Generated by Specter - Give your codebase a voice

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are minimal, consistent with the stated failures, and align CI pnpm setup with the existing packageManager pin while fixing specter-roast TypeScript type resolution.

Pull request overview

This PR fixes ongoing CI failures caused by a pnpm version pin conflict and resolves TypeScript type resolution issues when building the nested packages/specter-roast package.

Changes:

  • Removed the redundant version: 10 input from pnpm/action-setup@v6 in the CI workflow so the action relies on the root packageManager: "pnpm@10.32.1" pin.
  • Updated packages/specter-roast/tsconfig.json to explicitly include Node typings via "types": ["node"], fixing unresolved node:* imports and Node globals during tsc builds.
File summaries
File Description
packages/specter-roast/tsconfig.json Adds explicit Node type inclusion to make tsc resolve Node built-ins and globals for this package.
.github/workflows/ci.yml Removes conflicting pnpm version configuration so CI can install the pnpm version pinned in package.json.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@forbiddenlink
forbiddenlink merged commit e7cc542 into main Aug 26, 2026
10 checks passed
@forbiddenlink
forbiddenlink deleted the fix/ci-pnpm-version-conflict branch August 26, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants