feat: migrate CI to formancehq/ci shared workflows - #210
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (4)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
000a765 to
cbb62e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
===========================
===========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Approve — automated reviewThe previously reported deployment permission issue is fixed by explicitly granting contents read access. No other actionable defects were found. No findings. |
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot posted 1 new inline finding.
Summary: #210 (comment)
cbb62e4 to
0797f9b
Compare
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot review complete: no remaining inline findings.
Resolved 1 stale NumaryBot review thread (1 fixed, 0 outdated).
Summary: #210 (comment)
|
Review status: not ready for approval yet. The unit/integration split is preserved and green, but the privileged migration is not yet safe or demonstrated:
Please pin the shared CI version, isolate untrusted PR builds from credentials/publication, gate GoReleaser on the complete Tests job, pin/verify ArgoCD, and exercise build/release/deploy before approval. |
gfyrag
left a comment
There was a problem hiding this comment.
Re-reviewed the current SHA and green checks. The migration is acceptable within the explicitly agreed phase-1 scope. Approved; immutable CI pinning and the deferred publication hardening remain follow-up work.
No description provided.