Skip to content

fix(deps): update go-libs/v5 to v5.7.0 - #150

Closed
sofiasimdianova wants to merge 1 commit into
mainfrom
fix/deps-update
Closed

fix(deps): update go-libs/v5 to v5.7.0#150
sofiasimdianova wants to merge 1 commit into
mainfrom
fix/deps-update

Conversation

@sofiasimdianova

@sofiasimdianova sofiasimdianova commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated foundational components to newer versions, bringing compatibility improvements and maintenance updates.
    • No user-facing feature changes or API changes.

@sofiasimdianova
sofiasimdianova requested review from a team as code owners July 31, 2026 14:47
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a5bb57b-e6e7-49b0-9b1f-d18087e6de1f

📥 Commits

Reviewing files that changed from the base of the PR and between 1943b92 and 9b56726.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

The PR updates github.com/formancehq/go-libs/v5 to v5.7.0 and the indirect github.com/opencontainers/runc dependency to v1.3.6.

Changes

Dependency updates

Layer / File(s) Summary
Go module version updates
go.mod
Updates go-libs/v5 and indirect runc dependency versions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: gfyrag

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary dependency update to go-libs/v5 and matches the pull request changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deps-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NumaryBot

Copy link
Copy Markdown
Contributor

🛑 Changes requested — automated review

The dependency bump changes the default behavior of the HTTP audit middleware used by this service, causing audit events to stop being emitted unless the application is updated to opt in.

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumaryBot posted 1 new inline finding.

Summary: #150 (comment)

Comment thread go.mod
github.com/formancehq/auth/pkg/client v0.0.0-00010101000000-000000000000
github.com/formancehq/go-libs/v3 v3.6.1
github.com/formancehq/go-libs/v5 v5.1.1-0.20260522083443-d2a60ed2e0dd
github.com/formancehq/go-libs/v5 v5.7.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 [blocker] Keep HTTP audit enabled after go-libs bump

This update pulls in go-libs versions where httpaudit.Middleware no longer publishes events unless it is enabled via WithEnabled/WithConfig. The current call in pkg/api/module.go still only passes WithSensitivePaths, so after this bump every auth request will skip audit publishing, whereas the previous pseudo-version audited by default. Please wire the new audit config or explicitly enable the middleware where appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants