fix(deps): update go-libs/v5 to v5.7.0 - #150
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🛑 Changes requested — automated reviewThe dependency bump changes the default behavior of the HTTP audit middleware used by this service, causing audit events to stop being emitted unless the application is updated to opt in. |
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot posted 1 new inline finding.
Summary: #150 (comment)
| github.com/formancehq/auth/pkg/client v0.0.0-00010101000000-000000000000 | ||
| github.com/formancehq/go-libs/v3 v3.6.1 | ||
| github.com/formancehq/go-libs/v5 v5.1.1-0.20260522083443-d2a60ed2e0dd | ||
| github.com/formancehq/go-libs/v5 v5.7.0 |
There was a problem hiding this comment.
🔴 [blocker] Keep HTTP audit enabled after go-libs bump
This update pulls in go-libs versions where httpaudit.Middleware no longer publishes events unless it is enabled via WithEnabled/WithConfig. The current call in pkg/api/module.go still only passes WithSensitivePaths, so after this bump every auth request will skip audit publishing, whereas the previous pseudo-version audited by default. Please wire the new audit config or explicitly enable the middleware where appropriate.
Summary by CodeRabbit