Skip to content

feat: add reusable Go CI workflows and composite actions - #2

Closed
sofiasimdianova wants to merge 5 commits into
mainfrom
feat/reusable-workflows
Closed

feat: add reusable Go CI workflows and composite actions #2
sofiasimdianova wants to merge 5 commits into
mainfrom
feat/reusable-workflows

Conversation

@sofiasimdianova

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • .github/workflows/go-build.yml is excluded by !**/*.yml
  • .github/workflows/go-release.yml is excluded by !**/*.yml
  • .github/workflows/go-validate.yml is excluded by !**/*.yml
  • actions/setup-nix/action.yml is excluded by !**/*.yml
  • actions/setup-release/action.yml is excluded by !**/*.yml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: a204b4ba-9124-4da6-8209-0ef8690762e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands.

@NumaryBot

NumaryBot commented Jul 29, 2026

Copy link
Copy Markdown

🛑 Changes requested — automated review

The PR introduces reusable Go CI workflows and composite actions but has three confirmed issues that must be addressed before merging. Two major correctness issues were identified by multiple reviewers: (1) the setup-nix action redirects the entire stdout of the nix develop invocation into $GITHUB_OUTPUT, meaning any shellHook or setup-hook output will corrupt the output file and fail the step; (2) the Tests job in go-validate.yml calls setup-nix without forwarding the nix-extra-flags input, so repositories requiring flags like --accept-flake-config will fail during setup even though the later test command does forward those flags. Additionally, a blocker was identified by a single reviewer with clear evidence: the setup-release composite action references docker/login-action@v4 and docker/setup-qemu-action@v4, which do not exist — only v3 tags are published — causing action resolution to fail before any build or release step runs, since enable-docker defaults to true in both the build and release workflows.

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumaryBot posted 2 new inline findings.

Summary: #2 (comment)

Comment thread actions/setup-nix/action.yml Outdated
Comment thread actions/setup-nix/action.yml Outdated

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumaryBot posted 2 new inline findings.

Summary: #2 (comment)

Comment thread actions/setup-nix/action.yml Outdated
Comment thread .github/workflows/go-validate.yml

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumaryBot posted 3 new inline findings.

Summary: #2 (comment)

Comment thread actions/setup-release/action.yml
Comment thread actions/setup-nix/action.yml
Comment thread .github/workflows/go-validate.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants