chore(deps): upgrade go-libs to v5 - #180
Conversation
|
Warning Review limit reached
More reviews will be available in 35 minutes and 40 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (87)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
81c8226 to
a189f4e
Compare
| stackClientModule(cmd), | ||
| temporalworker.NewWorkerModule(temporalTaskQueue, worker.Options{ | ||
| TaskQueueActivitiesPerSecond: float64(temporalMaxParallelActivities), | ||
| TaskQueueActivitiesPerSecond: temporalMaxParallelActivities, |
There was a problem hiding this comment.
This now successfully reads temporal-max-parallel-activities, but it still wires that value to TaskQueueActivitiesPerSecond. The flag is documented as a concurrency limit, while this field is a queue-wide rate limit; with the v5 migration this starts enforcing the default 10 as 10 activities/second instead of 10 parallel activities. Please map it to MaxConcurrentActivityExecutionSize (with an integer value) so the upgrade does not introduce an unintended throughput cap.
|
Superseded by #199, which consolidates this change with the related reliability and safety fixes on top of the current main branch. |
Summary
github.com/formancehq/go-libs/v5tov5.3.0and remove the remaininggo-libs/v3dependencyValidation
go build ./...go test -run '^$' ./cmd ./internal/api ./internal/schema ./internal/temporalworker ./internal/tracer ./internal/workflow/activities ./internal/workflow/stages/... ./pkg/events\n-go test -cfor Docker-backed packages:./internal/api/v1,./internal/api/v2,./internal/storage,./internal/triggers,./internal/workflow\n\n## Note\n-go test ./...cannot complete locally because Docker is not reachable:dial unix /var/run/docker.sock: connect: connection refused.