Skip to content

chore(deps): upgrade go-libs to v5 - #180

Closed
flemzord wants to merge 1 commit into
mainfrom
fix/upgrade-go-libs-v5
Closed

chore(deps): upgrade go-libs to v5#180
flemzord wants to merge 1 commit into
mainfrom
fix/upgrade-go-libs-v5

Conversation

@flemzord

@flemzord flemzord commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

  • upgrade github.com/formancehq/go-libs/v5 to v5.3.0 and remove the remaining go-libs/v3 dependency
  • move imports to the new v5 package layout
  • adapt FX wiring for auth, licence, messaging, observability, storage, Temporal, health, and HTTP server hooks

Validation

  • go build ./...
  • go test -run '^$' ./cmd ./internal/api ./internal/schema ./internal/temporalworker ./internal/tracer ./internal/workflow/activities ./internal/workflow/stages/... ./pkg/events\n- go test -c for Docker-backed packages: ./internal/api/v1, ./internal/api/v2, ./internal/storage, ./internal/triggers, ./internal/workflow\n\n## Note\n- go test ./... cannot complete locally because Docker is not reachable: dial unix /var/run/docker.sock: connect: connection refused.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flemzord, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 40 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10ffffd2-a6a5-4b9e-a4e7-8c3e53eba6c4

📥 Commits

Reviewing files that changed from the base of the PR and between 271bf8d and a189f4e.

⛔ Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (87)
  • cmd/root.go
  • cmd/serve.go
  • cmd/worker.go
  • internal/api/backend.go
  • internal/api/backend_generated.go
  • internal/api/handler_info.go
  • internal/api/module.go
  • internal/api/module_test.go
  • internal/api/router.go
  • internal/api/v1/handler_abort_workflow_instance.go
  • internal/api/v1/handler_create_trigger.go
  • internal/api/v1/handler_create_workflow.go
  • internal/api/v1/handler_delete_trigger.go
  • internal/api/v1/handler_delete_workflow.go
  • internal/api/v1/handler_delete_workflow_test.go
  • internal/api/v1/handler_get_trigger.go
  • internal/api/v1/handler_list_instances.go
  • internal/api/v1/handler_list_instances_test.go
  • internal/api/v1/handler_list_triggers.go
  • internal/api/v1/handler_list_triggers_occurrences.go
  • internal/api/v1/handler_list_workflows.go
  • internal/api/v1/handler_post_event.go
  • internal/api/v1/handler_read_instance.go
  • internal/api/v1/handler_read_instance_history.go
  • internal/api/v1/handler_read_instance_test.go
  • internal/api/v1/handler_read_stage_history.go
  • internal/api/v1/handler_read_workflow.go
  • internal/api/v1/handler_run_workflow.go
  • internal/api/v1/handler_run_workflow_test.go
  • internal/api/v1/main_test.go
  • internal/api/v1/router.go
  • internal/api/v2/handler_abort_workflow_instance.go
  • internal/api/v2/handler_create_trigger.go
  • internal/api/v2/handler_create_workflow.go
  • internal/api/v2/handler_delete_trigger.go
  • internal/api/v2/handler_delete_workflow.go
  • internal/api/v2/handler_delete_workflow_test.go
  • internal/api/v2/handler_get_trigger.go
  • internal/api/v2/handler_list_instances.go
  • internal/api/v2/handler_list_instances_test.go
  • internal/api/v2/handler_list_triggers.go
  • internal/api/v2/handler_list_triggers_occurrences.go
  • internal/api/v2/handler_list_workflows.go
  • internal/api/v2/handler_post_event.go
  • internal/api/v2/handler_read_instance.go
  • internal/api/v2/handler_read_instance_history.go
  • internal/api/v2/handler_read_instance_test.go
  • internal/api/v2/handler_read_stage_history.go
  • internal/api/v2/handler_read_workflow.go
  • internal/api/v2/handler_run_workflow.go
  • internal/api/v2/handler_run_workflow_test.go
  • internal/api/v2/handler_test_trigger.go
  • internal/api/v2/handler_test_trigger_test.go
  • internal/api/v2/main_test.go
  • internal/api/v2/router.go
  • internal/schema/map.go
  • internal/storage/main_test.go
  • internal/storage/migrations.go
  • internal/storage/migrations_test.go
  • internal/temporalworker/module.go
  • internal/triggers/activities.go
  • internal/triggers/expression.go
  • internal/triggers/listener.go
  • internal/triggers/listener_test.go
  • internal/triggers/main_test.go
  • internal/triggers/manager.go
  • internal/triggers/module.go
  • internal/triggers/trigger.go
  • internal/triggers/workflow_trigger.go
  • internal/triggers/workflow_trigger_test.go
  • internal/workflow/activities/activity.go
  • internal/workflow/activities/activity_ledger_create_transaction.go
  • internal/workflow/activities/activity_wallet_credit.go
  • internal/workflow/activities/activity_wallet_debit.go
  • internal/workflow/activities/activity_wallet_list.go
  • internal/workflow/activities_test.go
  • internal/workflow/main_test.go
  • internal/workflow/manager.go
  • internal/workflow/manager_test.go
  • internal/workflow/stage.go
  • internal/workflow/stages/delay/delay.go
  • internal/workflow/stages/delay/run.go
  • internal/workflow/stages/delay/run_test.go
  • internal/workflow/stages/send/run.go
  • internal/workflow/stages/send/run_test.go
  • internal/workflow/stages/send/send.go
  • pkg/events/events.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/upgrade-go-libs-v5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@flemzord
flemzord force-pushed the fix/upgrade-go-libs-v5 branch from 81c8226 to a189f4e Compare June 4, 2026 10:50
@flemzord
flemzord requested a review from a team June 4, 2026 11:01
Comment thread cmd/worker.go
stackClientModule(cmd),
temporalworker.NewWorkerModule(temporalTaskQueue, worker.Options{
TaskQueueActivitiesPerSecond: float64(temporalMaxParallelActivities),
TaskQueueActivitiesPerSecond: temporalMaxParallelActivities,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now successfully reads temporal-max-parallel-activities, but it still wires that value to TaskQueueActivitiesPerSecond. The flag is documented as a concurrency limit, while this field is a queue-wide rate limit; with the v5 migration this starts enforcing the default 10 as 10 activities/second instead of 10 parallel activities. Please map it to MaxConcurrentActivityExecutionSize (with an integer value) so the upgrade does not introduce an unintended throughput cap.

@flemzord

flemzord commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Superseded by #199, which consolidates this change with the related reliability and safety fixes on top of the current main branch.

@flemzord flemzord closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant