chore: update payment version - #408
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR updates Helm chart versions in the root chart table and chart READMEs. It also updates the documented v3.2 Payments version from ChangesChart version documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Approve — automated reviewThe prior chart-version cascade issue is resolved at HEAD. All changed lockfiles have corresponding chart bumps, propagated through cloudprem to formance, with generated documentation kept consistent. No findings. |
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot posted 1 new inline finding.
Summary: #408 (comment)
Addresses review feedback on #408: lockfile changes were committed without bumping the owning charts, so consumers would never receive them as releases. Charts bumped: - regions 3.15.0 -> 3.15.1 (payments v3.4.0 -> v3.4.1 in values.yaml) - membership 3.6.2 -> 3.6.3 (postgresql 18.8.6 -> 18.8.8) - portal 3.7.1 -> 3.7.2 (postgresql 18.8.6 -> 18.8.8) - console-v3 3.7.1 -> 3.7.2 (postgresql 18.8.6 -> 18.8.8) - cloudprem 4.10.2 -> 4.10.3 (parent of membership/portal/console-v3) - formance 1.18.1 (umbrella: postgresql, regions, cloudprem) Constraint: Chart.lock digest is what pins a release, so any lock change requires bumping the owning chart and every parent up to formance Rejected: Revert the incidental postgresql 18.8.6 -> 18.8.8 lock refresh to keep the PR narrow | hand-editing Chart.lock is forbidden and just pre-commit re-resolves it on the next run Confidence: high Scope-risk: narrow Directive: All steps are patch-level upstream (payments and postgresql), so every chart bump is a patch. No appVersion changed -- the leaf app versions track their own services, not the postgresql sub-dependency.
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot review complete: no remaining inline findings.
Resolved 1 stale NumaryBot review thread (1 fixed, 0 outdated).
Summary: #408 (comment)
No description provided.