chore: update chart versions for cloudprem, console-v3, formance, and… - #411
chore: update chart versions for cloudprem, console-v3, formance, and…#411reslene wants to merge 1 commit into
Conversation
… portal Bumped the following chart versions: - cloudprem: 4.10.3 -> 5.0.0 - console-v3: 3.7.2 -> 4.0.0 - formance: 1.18.2 -> 2.0.0 - portal: 3.7.2 -> 4.0.0 Updated app versions accordingly to maintain consistency across dependencies.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (5)
WalkthroughThe pull request updates Helm chart README metadata for Cloudprem, Console-V3, Formance, and Portal. It changes chart and application versions in badges, updates documented dependency constraints, and refreshes the root chart listing. ChangesChart release metadata
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This PR updates chart and app versions across the listed components; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Approve — automated reviewThe chart, dependency, lockfile, app, and generated README versions are updated consistently, with no stale version references found. No findings. |
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "v2.6.2" | ||
| appVersion: "v3.1.0" |
There was a problem hiding this comment.
appVersion jumps from v2.6.2 to v3.1.0, skipping v3.0.0. is it intentional? why there was no v3.0.0? the same for console-v3
There was a problem hiding this comment.
Cloudprem is already on v3.1.0
We missed some update on helm repo...
If it's better, i can create all the PR missed until v3.1.0 ?
the versions that is not in helm history are:
v2.7.0
v3.0.0
what do you prefer ?
There was a problem hiding this comment.
it's not a blocker, but it's not best practice to skip version :(
There was a problem hiding this comment.
i'm gonna make the missing PR, it's better this way
There was a problem hiding this comment.
Portal was migrated from Remix to Next.js in platform-ui PR #1351. The old Remix app exposed /_info via apps/portal/app/routes/[_info].ts, but the new Next.js app no longer has apps/portal/app/_info/route.ts.
However, both readiness and liveness probes in https://github.com/formancehq/helm/blob/main/charts/portal/templates/deployment.yaml#L48
still use: GET /_info
With new version this will return 404, causing the pod to fail its health checks and potentially restart. can you recheck that please on your side ?
Helm expects: /_info
Next.js provides: /api/health
There was a problem hiding this comment.
@sofiasimdianova oh very good point, i do not know if the migration of @BrieucCaillot is having the healthcheck route, let me check this on my side.
There was a problem hiding this comment.
ok @sofiasimdianova i've just checked you were right, i'm gonna have to make a patch i'm afraid !
… portal
Bumped the following chart versions:
Updated app versions accordingly to maintain consistency across dependencies.