fix(benthos): revert Redpanda Connect upgrade

[flemzord]

Summary

• revert chore: replace benthos with redpanda/connect #463 and restore Benthos v4.23.1-es
• restore the /benthos command and the corresponding E2E expectations
• bump the operator and operator-crds Helm charts to 3.13.2 and regenerate Chart.lock

Context

Redpanda Connect 4.93.0 rejects the existing NATS JetStream input used with OneStreamByStack because the rendered configuration sets both queue and durable. This leaves the new Benthos pods in CrashLoopBackOff during the rollout.

Reverting the upgrade restores the last known-good runtime while keeping the existing NATS consumer semantics unchanged.

Validation

• just helm-validate
• KUBEBUILDER_ASSETS=$(setup-envtest use 1.32.0 -p path) ginkgo --focus='BenthosController' ./internal/tests
• git diff --check

just pre-commit was also attempted. The host run was blocked because the installed golangci-lint was built with Go 1.25 while the repository targets Go 1.26.1; the Nix run reached lint before being interrupted for immediate publication.

[coderabbitai]

Walkthrough

The Benthos deployment now uses the /benthos executable, version v4.23.1-es, and a public ECR image reference. Documentation describes accepted image reference formats.

Changes

Benthos image migration

Layer / File(s)	Summary
Update Benthos image runtime internal/resources/registries/image.go, internal/resources/benthos/controller.go	The controller now runs /benthos with version v4.23.1-es. GetBenthosImage now uses the public ECR registry. Comments document supported image reference formats.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: sylr

Poem

I hop through ECR with a bright little glow,
Benthos now runs where the old command would go.
A fresh version tucked in my carrot-filled nest,
With image formats documented best.
Squeak, deploy, and onward we spring!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Benthos change as a revert of the Redpanda Connect upgrade.
Description check	✅ Passed	The description directly explains the runtime revert, restored command, chart updates, failure context, and validation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/benthos-nats-queue-durable

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NumaryBot]

✅ Approve — automated review

The patch cleanly restores the previously working Benthos image, executable, and matching E2E expectations while consistently updating the Helm chart versions and lockfile.

No findings.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/resources/registries/image.go`:
- Line 14: Update the public ECR image example comment near GetBenthosImage to
include the generated :<version> tag, documenting a pinned reference rather than
an implicit latest image.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2033d5ef-44ea-4884-997f-bd7674e9cf3b

📥 Commits

Reviewing files that changed from the base of the PR and between 44378be and 142d9dc.

⛔ Files ignored due to path filters (5)

• docs/09-Configuration reference/settings.catalog.json is excluded by !**/*.json
• helm/crds/Chart.yaml is excluded by !**/*.yaml
• helm/operator/Chart.lock is excluded by !**/*.lock, !**/*.lock
• helm/operator/Chart.yaml is excluded by !**/*.yaml
• tests/e2e/chainsaw/23-benthos-module/chainsaw-test.yaml is excluded by !**/*.yaml

📒 Files selected for processing (2)

• internal/resources/benthos/controller.go
• internal/resources/registries/image.go

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Document the public ECR tag format.

Line 14 omits :<version>, but GetBenthosImage generates a tagged reference. Update the example to avoid suggesting an unpinned latest image.

Proposed fix

-// public.ecr.aws/<organization>/jeffail/benthos
+// public.ecr.aws/<organization>/jeffail/benthos:<version>

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// public.ecr.aws/<organization>/jeffail/benthos
	// public.ecr.aws/<organization>/jeffail/benthos:<version>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/resources/registries/image.go` at line 14, Update the public ECR
image example comment near GetBenthosImage to include the generated :<version>
tag, documenting a pinned reference rather than an implicit latest image.