Skip to content

fix(ledger): propagate JSON logging to v3 clusters - #524

Closed
Dav-14 wants to merge 1 commit into
feat/connectivity-api-authfrom
codex/ledger-v3-json-logging
Closed

fix(ledger): propagate JSON logging to v3 clusters#524
Dav-14 wants to merge 1 commit into
feat/connectivity-api-authfrom
codex/ledger-v3-json-logging

Conversation

@Dav-14

@Dav-14 Dav-14 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • propagate the platform-wide logging.json Setting to delegated Ledger v3 Cluster resources through JSON_FORMATTING_LOGGER=true
  • preserve LedgerConfiguration.spec.cluster.extraEnv, overriding a conflicting log-format value only while the Setting is enabled
  • document the behavior and update the generated Settings catalogue

Tests

  • nix develop --command just pre-commit
  • nix develop --command just tests (16 suites, all passing)
  • combined unit + integration coverage for internal/resources/ledgers: 80.1%
  • BDD integration coverage for configured false -> Setting true -> configured false, including preservation of unrelated env vars

Dependency

This is intentionally stacked on #522 (feat/connectivity-api-auth), which contains the corresponding delegated Connectivity JSON logging support. Rebase or retarget this PR after #522 lands.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b8ce59d1-63ad-4147-a94d-498a6345ea1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Dav-14 Dav-14 closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant