Skip to content

Exclude subspec names from OSS Name - #329

Merged
woocheol-lge merged 1 commit into
mainfrom
c_test
Jul 28, 2026
Merged

Exclude subspec names from OSS Name#329
woocheol-lge merged 1 commit into
mainfrom
c_test

Conversation

@woocheol-lge

@woocheol-lge woocheol-lge commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved CocoaPods handling by first checking whether the CocoaPods CLI is available, with a warning and graceful fallback when it isn’t.
    • Standardized CocoaPods dependency names by normalizing pod names (e.g., removing any / suffix).
    • Enhanced dependency name matching and assignment for items sourced externally to reduce misidentification.

@woocheol-lge woocheol-lge self-assigned this Jul 27, 2026
@woocheol-lge woocheol-lge added the chore [PR/Issue] Refactoring, maintenance the code label Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: abb000b3-d97c-4122-8f07-54f6041ba6ac

📥 Commits

Reviewing files that changed from the base of the PR and between 5ffdf0b and 7863b9f.

📒 Files selected for processing (1)
  • src/fosslight_dependency/package_manager/Cocoapods.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/fosslight_dependency/package_manager/Cocoapods.py

📝 Walkthrough

Walkthrough

The CocoaPods package manager now verifies that the pod CLI is available and normalizes pod names before processing dependency information.

Changes

CocoaPods processing updates

Layer / File(s) Summary
CocoaPods CLI availability
src/fosslight_dependency/package_manager/Cocoapods.py
Adds run_plugin() to check for pod with shutil.which, logging a warning and returning False when unavailable.
Pod name normalization
src/fosslight_dependency/package_manager/Cocoapods.py
Adds normalize_pod_name() and uses normalized names when constructing dependency items and checking external sources.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing CocoaPods subspec suffixes from OSS names.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch c_test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/fosslight_dependency/package_manager/Cocoapods.py (1)

105-110: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add regression coverage for normalized subspec names.

Cover regular and external-source cases such as Foo/Bar, asserting the emitted OSS name is cocoapods:Foo, the podspec lookup uses Foo, and dependency-to-PURL mapping remains correct.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/fosslight_dependency/package_manager/Cocoapods.py` around lines 105 -
110, Add regression tests for the pod processing flow around normalize_pod_name,
covering regular and external-source inputs such as Foo/Bar. Assert the emitted
OSS name is cocoapods:Foo, podspec lookup uses Foo, and dependency-to-PURL
mapping remains correct.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/fosslight_dependency/package_manager/Cocoapods.py`:
- Around line 105-110: Add regression tests for the pod processing flow around
normalize_pod_name, covering regular and external-source inputs such as Foo/Bar.
Assert the emitted OSS name is cocoapods:Foo, podspec lookup uses Foo, and
dependency-to-PURL mapping remains correct.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4fe72e17-e371-48db-80c0-01c9c903f080

📥 Commits

Reviewing files that changed from the base of the PR and between df872d6 and 5ffdf0b.

📒 Files selected for processing (1)
  • src/fosslight_dependency/package_manager/Cocoapods.py

Comment thread src/fosslight_dependency/package_manager/Cocoapods.py Outdated
Signed-off-by: woocheol <jayden6659@gmail.com>
@woocheol-lge
woocheol-lge merged commit abcefff into main Jul 28, 2026
14 checks passed
@woocheol-lge
woocheol-lge deleted the c_test branch July 28, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants