Skip to content

Add failure logging for Java version validation in Gradle, Android, and Maven - #333

Merged
dd-jy merged 1 commit into
mainfrom
l_test
Aug 7, 2026
Merged

Add failure logging for Java version validation in Gradle, Android, and Maven#333
dd-jy merged 1 commit into
mainfrom
l_test

Conversation

@woocheol-lge

@woocheol-lge woocheol-lge commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved analysis reporting so all package-manager messages are retained, including Java compatibility issues.
    • Ensured cover comments are captured consistently for both successful and failed analyses.
    • Added clearer fallback guidance when no analysis comments are available.
    • Cleaned and standardized dependency references by removing empty entries, duplicates, and extra whitespace.

@woocheol-lge woocheol-lge self-assigned this Aug 7, 2026
@woocheol-lge woocheol-lge added the chore [PR/Issue] Refactoring, maintenance the code label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@woocheol-lge, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d0642c66-55c0-4b68-8565-9ff26216ff4d

📥 Commits

Reviewing files that changed from the base of the PR and between 0454e8c and 787a91b.

📒 Files selected for processing (4)
  • src/fosslight_dependency/_analyze_dependency.py
  • src/fosslight_dependency/_package_manager.py
  • src/fosslight_dependency/dependency_item.py
  • src/fosslight_dependency/run_dependency_scanner.py
📝 Walkthrough

Walkthrough

The change records Java compatibility warnings as cover comments, aggregates comments from package-manager analyses, and includes them in the dependency summary. Dependency setters now remove blank values, deduplicate entries, and sort stored lists.

Changes

Cover comment handling

Layer / File(s) Summary
Capture package-manager cover comments
src/fosslight_dependency/_package_manager.py, src/fosslight_dependency/_analyze_dependency.py
Java compatibility warnings use set_cover_comment. Analysis captures cover_comment after both success and failure paths.
Aggregate analysis cover comments
src/fosslight_dependency/run_dependency_scanner.py
Manual and manifest-based analyses append comments to a shared collection. The final summary includes all collected comments. Existing guidance remains when no comments exist.

Dependency value normalization

Layer / File(s) Summary
Normalize dependency values
src/fosslight_dependency/dependency_item.py
depends_on and depends_on_raw remove blank values, deduplicate entries, and store them in sorted order.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: bjk7119, dd-jy

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: failure logging for Java version validation in Gradle, Android, and Maven.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch l_test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/fosslight_dependency/run_dependency_scanner.py`:
- Around line 469-473: Move the cover_comments append logic out of the
fail_pm-only block so collected comments are added to log_lines even when final
fail_pm is empty; keep the prerequisite fallback message conditional on fail_pm,
and add a regression test covering a collected comment after duplicate
Gradle/Android failure removal.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e8625d86-aa32-4d60-a9c7-2c588835aff5

📥 Commits

Reviewing files that changed from the base of the PR and between 0454e8c and 725e0b8.

📒 Files selected for processing (4)
  • src/fosslight_dependency/_analyze_dependency.py
  • src/fosslight_dependency/_package_manager.py
  • src/fosslight_dependency/dependency_item.py
  • src/fosslight_dependency/run_dependency_scanner.py

Comment thread src/fosslight_dependency/run_dependency_scanner.py Outdated
…adle, Android, and Maven

Signed-off-by: woocheol <jayden6659@gmail.com>
@dd-jy
dd-jy merged commit b6a04ed into main Aug 7, 2026
14 checks passed
@dd-jy
dd-jy deleted the l_test branch August 7, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants