Use an absolute, quoted path for the maven wrapper

[bjk7119]

Summary by CodeRabbit

• Bug Fixes
  • Improved Maven command execution when project paths contain spaces or special characters.
  • Fixed Maven wrapper discovery to work reliably from different working directories.
  • Improved compatibility with Windows command execution settings.

[coderabbitai]

Warning

Review limit reached

@bjk7119, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3cfd7e02-7105-48c7-98da-d9904e79583b

📥 Commits

Reviewing files that changed from the base of the PR and between ed6026b and fbc4250.

📒 Files selected for processing (1)

• src/fosslight_dependency/package_manager/Maven.py

📝 Walkthrough

Walkthrough

Maven command paths now use shell-safe quoting. Maven wrapper discovery returns an absolute path. Plugin, source-download, and dependency-resolution commands use the quoted executable path.

Changes

Maven path-safe execution

Layer / File(s)	Summary
Command path quoting src/fosslight_dependency/package_manager/Maven.py	The module adds quote_cmd_path, with Windows double-quoting and POSIX shell quoting.
Maven command integration src/fosslight_dependency/package_manager/Maven.py	Wrapper discovery returns an absolute path. Plugin, source-download, and fallback dependency-resolution commands use the quoted Maven path.

Estimated code review effort: 3 (Moderate) | ~15–30 minutes

Suggested reviewers: woocheol-lge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: using an absolute, quoted Maven wrapper path.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch maven-abspath

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/fosslight_dependency/package_manager/Maven.py`:
- Around line 193-198: Update _get_mvn_cmd() to construct the Windows and Unix
Maven wrapper paths under self.input_dir, then check those absolute paths
instead of process-relative mvnw and mvnw.cmd entries. Preserve the
platform-specific selection and pass the resolved wrapper path through the
existing change_file_mode flow.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 98257be6-f693-4055-9128-edbb74db8c36

📥 Commits

Reviewing files that changed from the base of the PR and between b6a04ed and ed6026b.

📒 Files selected for processing (1)

• src/fosslight_dependency/package_manager/Maven.py