Skip to content

Create the temporary virtualenv with the running interpreter - #335

Merged
dd-jy merged 1 commit into
mainfrom
venv-interpreter
Aug 24, 2026
Merged

Create the temporary virtualenv with the running interpreter#335
dd-jy merged 1 commit into
mainfrom
venv-interpreter

Conversation

@bjk7119

@bjk7119 bjk7119 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved Python virtual environment setup by using the active Python interpreter when available.
    • Added a fallback option to improve compatibility when the active interpreter cannot be detected.

@bjk7119 bjk7119 self-assigned this Aug 8, 2026
@bjk7119 bjk7119 added the chore [PR/Issue] Refactoring, maintenance the code label Aug 8, 2026
@bjk7119
bjk7119 requested a review from dd-jy August 8, 2026 04:18
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e87d9a12-2ec4-409b-b0ce-736deba1d83f

📥 Commits

Reviewing files that changed from the base of the PR and between b6a04ed and fdf4738.

📒 Files selected for processing (1)
  • src/fosslight_dependency/package_manager/Pypi.py

📝 Walkthrough

Walkthrough

The PyPI package manager now selects the running Python interpreter, shell-quotes it, and uses it for virtual environment creation and POSIX fallback retries.

Changes

PyPI virtual environment setup

Layer / File(s) Summary
Running interpreter selection
src/fosslight_dependency/package_manager/Pypi.py
Adds venv_interpreter(fallback), which returns a shell-quoted sys.executable or the provided fallback.
Virtualenv command wiring
src/fosslight_dependency/package_manager/Pypi.py
Uses the selected interpreter for Windows venv creation, POSIX virtualenv -p, and POSIX -m venv retry commands.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: woocheol-lge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: creating the temporary virtual environment with the running Python interpreter.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch venv-interpreter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bjk7119 bjk7119 added bug fix [PR] Fix the bug and removed chore [PR/Issue] Refactoring, maintenance the code labels Aug 8, 2026
@dd-jy
dd-jy merged commit d454b1a into main Aug 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix [PR] Fix the bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants