Skip to content

fix(scanner): remove deprecated binary db_url option - #197

Merged
soimkim merged 1 commit into
mainfrom
url
Aug 27, 2026
Merged

fix(scanner): remove deprecated binary db_url option#197
soimkim merged 1 commit into
mainfrom
url

Conversation

@soimkim

@soimkim soimkim commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
  • Changes
    • Removed the database URL option from the command-line interface and configuration settings.
    • Updated scanner commands and configuration handling to use knowledge-base settings and merge controls instead.
    • Simplified scanner invocation options by removing obsolete database connection inputs.
    • Updated help text and examples to accurately reflect the available options.

Binary DB lookup now uses ldb_service via kb_url/kb_token only.
Remove -u CLI flag, setting.json db_url, and related help text.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 24aca232-123b-488c-9dda-711a4712e760

📥 Commits

Reviewing files that changed from the base of the PR and between 3bc404a and 4a97fe7.

📒 Files selected for processing (9)
  • src/fosslight_scanner/_help.py
  • src/fosslight_scanner/_parse_setting.py
  • src/fosslight_scanner/cli.py
  • src/fosslight_scanner/fosslight_scanner.py
  • tests/fixtures/scan_project/sample_code.py
  • tests/fixtures/setting.json
  • tests/test__parse_setting.py
  • tests/test_cli.py
  • tests/test_fosslight_scanner.py
💤 Files with no reviewable changes (3)
  • tests/fixtures/setting.json
  • tests/test_fosslight_scanner.py
  • src/fosslight_scanner/_help.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The scanner removes database URL support from settings parsing, CLI arguments, scanner APIs, help text, fixtures, and tests. Argument and tuple ordering now passes timer directly after link.

Changes

Database URL removal

Layer / File(s) Summary
Settings and CLI contracts
src/fosslight_scanner/_parse_setting.py, src/fosslight_scanner/cli.py, src/fosslight_scanner/_help.py
Database URL parsing, fallback handling, returned values, and the --url/-u option were removed.
Scanner API wiring
src/fosslight_scanner/fosslight_scanner.py
run_main and run_scanner no longer accept or forward db_url.
Fixtures and validation
tests/fixtures/scan_project/sample_code.py, tests/fixtures/setting.json, tests/test__parse_setting.py, tests/test_cli.py, tests/test_fosslight_scanner.py
Fixtures and tests were updated to match the new argument and return-value shapes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4a97f

This localized cleanup removes a deprecated binary database option and related help and test references; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: dd-jy, justinwonjaepark

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 6 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the primary change: removal of the deprecated binary db_url option and related configuration support.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim soimkim self-assigned this Aug 27, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Aug 27, 2026
@soimkim
soimkim merged commit cbfe7b4 into main Aug 27, 2026
6 of 7 checks passed
@soimkim
soimkim deleted the url branch August 27, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant