Skip to content

Change logging level of SPDX extraction failures - #308

Merged
JustinWonjaePark merged 1 commit into
mainfrom
chore/spdx_logging
Aug 21, 2026
Merged

Change logging level of SPDX extraction failures#308
JustinWonjaePark merged 1 commit into
mainfrom
chore/spdx_logging

Conversation

@JustinWonjaePark

@JustinWonjaePark JustinWonjaePark commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
  • Reduced the visibility of a non-critical diagnostic message without changing application behavior.

@JustinWonjaePark JustinWonjaePark self-assigned this Aug 21, 2026
@JustinWonjaePark JustinWonjaePark added the chore [PR/Issue] Refactoring, maintenance the code label Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bf26278b-6c06-4d6c-b5b8-5d7d1b3ee334

📥 Commits

Reviewing files that changed from the base of the PR and between 33073f1 and 5453784.

📒 Files selected for processing (1)
  • src/fosslight_source/run_spdx_extractor.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The SPDX extractor now logs extraction failures at debug level. Exception handling and returned results remain unchanged.

Changes

SPDX extraction logging

Layer / File(s) Summary
Adjust extraction failure logging
src/fosslight_source/run_spdx_extractor.py
get_spdx_downloads changes extraction failure logging from logger.warning to logger.debug. Control flow and returned results remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 54537

This is a narrowly scoped logging behavior change, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: changing the logging level for SPDX extraction failures.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/spdx_logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JustinWonjaePark
JustinWonjaePark marked this pull request as ready for review August 21, 2026 02:19
@JustinWonjaePark JustinWonjaePark changed the title fix: keep SPDX extraction failures out of console Change logging level of SPDX extraction failures Aug 21, 2026
@JustinWonjaePark
JustinWonjaePark merged commit ca8c3bc into main Aug 21, 2026
7 of 8 checks passed
@JustinWonjaePark
JustinWonjaePark deleted the chore/spdx_logging branch August 21, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant