Skip to content

Restore Soong SPDX-license-identifier from unknown-spdx matches. - #311

Merged
soimkim merged 1 commit into
mainfrom
lic
Aug 25, 2026
Merged

Restore Soong SPDX-license-identifier from unknown-spdx matches.#311
soimkim merged 1 commit into
mainfrom
lic

Conversation

@soimkim

@soimkim soimkim commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Parse SPDX-license-identifier-* before generic SPDX extraction and strip line comments so Android.bp license_kinds no longer leak trailing // text into license tokens.

ex.
Apache-2.0,unknown-license-reference,MIT,OFL", // by exception only,BSD -> Apache-2.0,unknown-license-reference,MIT,BSD,OFL

Parse SPDX-license-identifier-* before generic SPDX extraction and strip line comments so Android.bp license_kinds no longer leak trailing // text into license tokens.
@soimkim soimkim self-assigned this Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 1 minute.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cad85b57-cf21-40e4-8543-36a0377412ed

📥 Commits

Reviewing files that changed from the base of the PR and between b566275 and e53cef8.

📒 Files selected for processing (2)
  • src/fosslight_source/_parsing_scancode_file_item.py
  • tests/test_parsing_unknown_spdx.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim soimkim added the bug fix [PR] Fix the bug label Aug 25, 2026
@soimkim
soimkim merged commit 3a55d1f into main Aug 25, 2026
6 of 8 checks passed
@soimkim soimkim changed the title fix: restore Soong SPDX-license-identifier from unknown-spdx matches. Restore Soong SPDX-license-identifier from unknown-spdx matches. Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix [PR] Fix the bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant