Skip to content

Include DEP sheets and relax empty-row filter - #300

Open
bjk7119 wants to merge 2 commits into
mainfrom
compare
Open

Include DEP sheets and relax empty-row filter#300
bjk7119 wants to merge 2 commits into
mainfrom
compare

Conversation

@bjk7119

@bjk7119 bjk7119 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Preserved OSS items when some metadata is available, even if name, version, or license details are incomplete.
    • Included dependency sheets when automatically parsing OSS reports.

@bjk7119
bjk7119 requested a review from dd-jy August 10, 2026 08:43
@bjk7119 bjk7119 self-assigned this Aug 10, 2026
@bjk7119 bjk7119 added the chore [PR/Issue] Refactoring, maintenance the code label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@bjk7119, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4490698e-02d4-4e53-9e98-5b85d272f6f8

📥 Commits

Reviewing files that changed from the base of the PR and between e383f94 and 295b568.

📒 Files selected for processing (1)
  • src/fosslight_util/compare_yaml.py
📝 Walkthrough

Walkthrough

The changes retain OSS items with partial metadata and include dep sheets in automatic Excel report parsing.

Changes

OSS report parsing

Layer / File(s) Summary
Partial OSS metadata retention
src/fosslight_util/compare_yaml.py
Items are skipped only when their name, version, and license are all empty.
Dependency sheet inclusion
src/fosslight_util/read_excel.py
The default sheet-prefix list now includes dep.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: dd-jy

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes both changes: including DEP sheets and retaining rows with partial metadata.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch compare

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/fosslight_util/compare_yaml.py`:
- Line 84: The comparison logic around the empty-field check must prevent
nameless OSS items from colliding on the shared NAME key. Update compare_yaml to
assign a stable identity for items with empty names or exclude them from
matching, while preserving valid matching for named items; add regression
coverage for distinct partial records with empty names.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a355151f-021d-4c01-9258-944092b28b91

📥 Commits

Reviewing files that changed from the base of the PR and between c586cce and e383f94.

📒 Files selected for processing (2)
  • src/fosslight_util/compare_yaml.py
  • src/fosslight_util/read_excel.py

Comment thread src/fosslight_util/compare_yaml.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants