Skip to content

Add Android applications plugin#1765

Open
JSCU-CNI wants to merge 2 commits into
fox-it:mainfrom
JSCU-CNI:android-applications
Open

Add Android applications plugin#1765
JSCU-CNI wants to merge 2 commits into
fox-it:mainfrom
JSCU-CNI:android-applications

Conversation

@JSCU-CNI

Copy link
Copy Markdown
Contributor

This PR adds an Android applications plugin and an Android AXML parser (not to be confused with ABX or regular XML). Depends on #1761.

"""Yield installed Android apps."""
for package_file in self.target.fs.path("/").glob("*/system/packages.xml"):
try:
root = read_android_xml(package_file.open("rb"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a context manager?

Comment on lines +165 to +166
fs = ZipFilesystem(path.open())
et = read_android_xml(fs.get("AndroidManifest.xml").open())

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use context managers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants