fix: Look up rapier physics states by cached tick tag - #647
Open
realpoke wants to merge 1 commit into
Open
Conversation
The rolling cache drops entries from the front once full, and a tick can be cached more than once while history is rewritten, so deriving the state index from the tick no longer matches what's stored. Look up the state by its cached tag instead (rfind, oldest first), and leave the space untouched if the tick is no longer cached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rapier drivers derived the state index from the tick, but the rolling cache drops entries from the front once full and a tick can be cached more than once while history is rewritten, so the wrong state could be restored.
States are now looked up by their cached tag instead, and if the tick is no longer cached the space is left untouched. Applied to both 2D and 3D drivers, which remain opt-in (.off).