fix: Keep rollback input labels collision-free across input delay changes - #648
Open
realpoke wants to merge 1 commit into
Open
fix: Keep rollback input labels collision-free across input delay changes#648realpoke wants to merge 1 commit into
realpoke wants to merge 1 commit into
Conversation
…nges Input labels are computed as tick + input_delay. When input_delay changes at runtime, consecutive ticks can produce duplicate labels (delay decreased) or skip labels entirely (delay increased). Local history and remote receivers then disagree about which input belongs to which tick, corrupting rollback for the affected range. Track the last submitted label: skip labels that would collide, and backfill skipped labels with the current input so the stream stays gap-free.
realpoke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input labels are tick +
input_delay, so changinginput_delayat runtime makes consecutive ticks produce duplicate labels (delay decreased) or skip labels (delay increased).Local history and remote receivers then disagree about which input belongs to which tick and rollback corrupts for that range.
We now track the last submitted label, colliding labels are skipped and skipped labels are backfilled with the current input so the stream stays collision-free and gap-free.