fix: Emit synchronization state only after merging into history - #649
Open
realpoke wants to merge 1 commit into
Open
fix: Emit synchronization state only after merging into history#649realpoke wants to merge 1 commit into
realpoke wants to merge 1 commit into
Conversation
_on_state was emitted even when _merge_rollback_state rejected the snapshot (e.g. stale or out-of-history data), letting consumers react to state that was never recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_on_statewas emitted even when_merge_rollback_staterejected the snapshot, for example stale or out-of-history data, so consumers could react to state that was never actually recorded.The emission is now gated on the merge succeeding.