Skip to content

ci: check the Worker configs against the code before deploying #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nplusonedev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: check the Worker configs against the code before deploying #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9300096
ci: check the Worker configs against the code before deploying
nplusonedev Aug 14, 2026
76d7c1c
ci: dry-run the configs before the suite, not after
nplusonedev Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,19 @@ jobs:
- run: pnpm install --frozen-lockfile
- run: pnpm lint
- run: pnpm typecheck
# wrangler.jsonc names code that no TypeScript gate checks: entrypoints,
# and Durable Object classes the entrypoint must export. Rename a class
# without its binding and lint, typecheck and test all stay green — the
# first failure is the deploy below, after migrations have been applied.
# `--containers-rollout none` keeps this to the bundle: without it a dry
# run still builds every container image, which the deploy jobs then
# build again. BEFORE `pnpm test`, deliberately: these cost seconds and
# the suite costs minutes, so on the main-push run a config that names
# missing code reds this job without waiting out the suite. After
# `typecheck`, also deliberately: a real code error should fail with the
# typechecker's message, not esbuild's.
- run: pnpm exec wrangler deploy --dry-run --containers-rollout none
- run: pnpm exec wrangler deploy --dry-run --containers-rollout none -c apps/substrate/wrangler.jsonc
- run: pnpm test

# The substrate deploys BEFORE the dispatcher, and its own job rather than a
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ BYOC CI/CD that offloads the expensive half of GitHub Actions onto a Cloudflare

## Status

Working monorepo: Effect-TS DSL (`packages/core`), capability layers (`packages/runtime-cf`), run definitions (`runs/`), the dispatcher Worker (`apps/dispatcher`), the substrate (`apps/substrate`), and the bundled CLIs (`packages/demo-agent`, `packages/review-agent`). Deployed via `wrangler deploy` with container images built in-repo (`infra/Dockerfile.sandbox*`); CI runs `pnpm lint && pnpm typecheck && pnpm test` (`deploy.yml`).
Working monorepo: Effect-TS DSL (`packages/core`), capability layers (`packages/runtime-cf`), run definitions (`runs/`), the dispatcher Worker (`apps/dispatcher`), the substrate (`apps/substrate`), and the bundled CLIs (`packages/demo-agent`, `packages/review-agent`). Deployed via `wrangler deploy` with container images built in-repo (`infra/Dockerfile.sandbox*`); CI runs `pnpm lint && pnpm typecheck`, then `wrangler deploy --dry-run` for both workers — so a Worker config that names missing code fails before anything deploys — then `pnpm test` (`deploy.yml`).

## Architecture

Expand Down
Loading