feat(diagnose): show per-check execution time in text output - #57
Merged
francomano merged 1 commit intoSep 2, 2026
Merged
Conversation
formatText rendered each check's status, severity and confidence but dropped the ExecutionTime that every check already records, so users could not tell which check was slow. Append the duration, human-readable via time.Duration.String() (e.g. [1.2s], [350ms]), to each result's status line. JSON/HTML/Markdown output already carried the field. Closes francomano#43
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43
Summary
formatTextrendered each check's status, severity and confidence but dropped theExecutionTimethat every check already records viaSetExecutionTime. Users could not tell which check was slow from the text output, even though the data was already onCheckResultand present in the JSON/HTML/Markdown outputs.Append the duration to each result's status line, human-readable via
time.Duration.String():Changes
cmd/cli/commands/diagnose.go—formatTextappends[%s](the result'sExecutionTime) to the status line.cmd/cli/commands/diagnose_test.go—TestFormatTextIncludesPerCheckExecutionTimebuilds a report with per-result durations (1.2s, 350ms) and asserts both bracketed, human-readable forms appear.Acceptance criteria (#43)
1.2s,350ms)Verification