Skip to content

fix(ci): restore pages/id-token permissions on the docs deploy job - #23

Merged
phpclub merged 1 commit into
freeunitorg:mainfrom
andypost:fix/docs-deploy-permissions
Jul 17, 2026
Merged

fix(ci): restore pages/id-token permissions on the docs deploy job#23
phpclub merged 1 commit into
freeunitorg:mainfrom
andypost:fix/docs-deploy-permissions

Conversation

@andypost

Copy link
Copy Markdown

The docs site stopped deploying after the recent main changes — the main runs fail with startup_failure and nothing reaches docs.freeunit.org.

Cause: the call-docs-build-push job in docs.yml lost its job-level permissions: block (removed in the recent fix(ci) commits). The reusable docs-build-push.yml deploy job requests pages: write + id-token: write, but a reusable-workflow job cannot exceed the calling job's grant — which was only the root contents: read. GitHub rejects this before any job runs → startup_failure → no deploy.

Fix: restore the permissions: block on call-docs-build-push (exactly what was present at f03c594, when #20 last deployed successfully):

  call-docs-build-push:
    uses: freeunitorg/docs/.github/workflows/docs-build-push.yml@main
    permissions:
      pull-requests: write
      contents: read
      pages: write
      id-token: write
    with:
      ...

Merging this to main retriggers the deploy, which should now succeed and publish the 1.36.0 docs.

The call-docs-build-push job dropped its job-level permissions block, so
the reusable workflow's deploy job (which needs pages: write + id-token:
write) exceeded the caller grant (contents: read) and the run failed at
startup — the site stopped deploying. Restore the block that was present
when #20 last deployed successfully.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DYcuURscruaF1yNVHJHW3C
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@phpclub
phpclub merged commit 2c54195 into freeunitorg:main Jul 17, 2026
@andypost
andypost deleted the fix/docs-deploy-permissions branch July 17, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants