fix(ci): restore pages/id-token permissions on the docs deploy job - #23
Merged
Merged
Conversation
The call-docs-build-push job dropped its job-level permissions block, so the reusable workflow's deploy job (which needs pages: write + id-token: write) exceeded the caller grant (contents: read) and the run failed at startup — the site stopped deploying. Restore the block that was present when #20 last deployed successfully. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DYcuURscruaF1yNVHJHW3C
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs site stopped deploying after the recent
mainchanges — themainruns fail withstartup_failureand nothing reaches docs.freeunit.org.Cause: the
call-docs-build-pushjob indocs.ymllost its job-levelpermissions:block (removed in the recentfix(ci)commits). The reusabledocs-build-push.ymldeploy job requestspages: write+id-token: write, but a reusable-workflow job cannot exceed the calling job's grant — which was only the rootcontents: read. GitHub rejects this before any job runs →startup_failure→ no deploy.Fix: restore the
permissions:block oncall-docs-build-push(exactly what was present atf03c594, when #20 last deployed successfully):Merging this to
mainretriggers the deploy, which should now succeed and publish the 1.36.0 docs.