fix(csp): warn when useNonce falls back to unsafe-inline#3881
Open
sanjibani wants to merge 1 commit into
Open
Conversation
A route handler that returns ctx.html(), ctx.json(), or ctx.text() instead of ctx.render() never sets the nonce on the response, so the CSP middleware silently falls back to the default directives with 'unsafe-inline' in script-src / style-src. The user opted into useNonce to lock the policy down — getting 'unsafe-inline' instead is a real security regression and they have no way to tell. Emit a console.warn with the route path so the developer knows the handler needs to switch to ctx.render(). Two new tests cover the warning in both the fallback and no-fallback cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route handlers returning ctx.html() / ctx.json() / ctx.text() instead of ctx.render() never set the nonce, so the CSP middleware silently serves the default 'unsafe-inline' directives. The user opted into useNonce to lock the policy down — silently getting 'unsafe-inline' is a real security regression they can't detect.
Emit a console.warn with the offending pathname so the developer knows which handler needs to switch to ctx.render(). Two new tests assert the warning fires on the fallback path and stays silent on the rendered path.
Fixes #3859.