Add shared terrain interaction v2 validator#117
Merged
ogyrec-o merged 1 commit intoMay 26, 2026
Conversation
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the shared Terrain Interaction Contract v2 validator to
freven_block_api.This makes the SDK the legal shared owner of terrain break/place validation semantics so engine and Vanilla can use one implementation without dependency inversion or duplicated validator math.
Why
frevenengine/freven-vanilla#75 blocked runtime v2 wiring because the validator lived in
freven_client_engine. Vanilla must not depend on engine internals, and copying the validator into Vanilla would create a second authority implementation and risk divergent server validation semantics.What changed
freven_block_api::terrain_interaction.validate_terrain_interaction_v2TerrainInteractionValidationPolicyV2TerrainInteractionValidationV2TerrainInteractionAcceptedV2TerrainInteractionWorldViewV2TerrainInteractionRulesV2TerrainInteractionCellV2BlockWorldViewTerrainAdapterTerrainInteractionIntentV2TerrainInteractionKindV2TerrainInteractionRayV2TerrainInteractionHitV2TerrainPlaceIntentV2TerrainInteractionRejectReasonV2freven_block_api::terrain_interactionas the long-term shared validator owner.Boundaries
Validation
cargo +stable fmt --all -- --checkcargo +stable test --locked -p freven_block_api terrain_interactioncargo +stable test --locked --workspacecargo +stable clippy --locked --workspace --all-targets -- -D warningscargo +stable clippy --locked --workspace --all-targets --all-features -- -D warningsgit --no-pager diff --checkRelated: