Report terrain validation trace diagnostics#121
Merged
Conversation
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a non-breaking terrain interaction validation report API with server-authoritative ray trace diagnostics.
Why
frevenengine/freven-engine#386 rapid LMB smoke now has one remaining rare rollback after #120:
Occluded.Occludedmust not be blindly relaxed because it protects against breaking through another block. To diagnose correctly, runtime/server code needs to know which authoritative trace hit caused the rejection without duplicating DDA logic outside the shared validator.What changed
TerrainInteractionTraceHitV2.TerrainInteractionTraceV2.TerrainInteractionValidationReportV2.validate_terrain_interaction_v2_report(...).validate_terrain_interaction_v2(...)API source-compatible by delegating to the report API.Boundaries
Validation
cargo +stable fmt --all -- --checkcargo +stable test --locked -p freven_block_api terrain_interactioncargo +stable test --locked --workspacecargo +stable clippy --locked --workspace --all-targets -- -D warningsgit --no-pager diff --checkRelated: