fix invalid regex modifier for key validator - #3
Open
daniil-berg wants to merge 1 commit into
Open
Conversation
The `g` modifier is not valid for `preg_grep` (or `preg_match`). The default for `$VALIDATOR` set in the constructor is now `'/./'`. The `empty` check in the `validate_key` method is no longer needed. Using `preg_match` is simpler and more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gmodifier is not valid forpreg_grep(orpreg_match).The default for
$VALIDATORset in the constructor is now'/./'. Theemptycheck in thevalidate_keymethod is no longer needed.Using
preg_matchis simpler and more readable.