chore: Drop support for playwright 1.60 - #58
Conversation
… support for 1.60)
… support for 1.60)
… support for 1.60)
… support for 1.60)
… support for 1.60)
# Conflicts: # test/playwright_ex/page_test.exs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1aec73ad4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| |> matches?(is_not) | ||
| end | ||
|
|
||
| defp matches?({:error, {%{error: %{name: "ExpectError"}}, %{timed_out: true}}}, is_not), do: {:ok, is_not} |
There was a problem hiding this comment.
When Playwright 1.61 returns a valid Frame.expect assertion failure with error_details.timed_out: false—for example, an expectation that terminates before its deadline—this clause does not match and the next clause exposes it as {:error, ...}. Playwright identifies an unsatisfied expectation by the ExpectError plus assertion details, while timed_out only describes the failure; recognize these responses regardless of that boolean so Frame.expect/2 consistently returns the documented match result.
Useful? React with 👍 / 👎.
… support for 1.60)
… support for 1.60) (#184) Based on [Wigny/phoenix_test_playwright#add-assert-screenshot](https://github.com/Wigny/phoenix_test_playwright/tree/add-assert-screenshot)
1 participant
No description provided.