chore: remove redundant dev dependencies (@types/uuid, pinst) - #392
Open
jimmycallin wants to merge 1 commit into
Open
chore: remove redundant dev dependencies (@types/uuid, pinst)#392jimmycallin wants to merge 1 commit into
jimmycallin wants to merge 1 commit into
Conversation
- Drop @types/uuid: uuid v14 ships its own type declarations, so the separate @types stub is dead weight (tsc passes without it). - Drop pinst and modernise the husky setup: husky is already v9, where the recommended hook installer is `prepare: husky`. Since `prepare` does not run when the package is installed as a dependency, the pinst dance (postinstall + prepack/postpack disable/enable) is no longer needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthrough
ChangesLifecycle script and dependency cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two devDependencies that are no longer pulling their weight.
@types/uuiduuid v14 ships its own type declarations (
"types": "./dist/index.d.ts"), so the separate@types/uuid@^11stub is dead weight — a leftover from older uuid versions.tscpasses without it.pinstpinstexisted only to neutralisepostinstall: husky installwhen publishing (so consumers don't run husky). But husky is already v9, where:husky installis deprecated — the command is now justhusky, and"prepare": "husky".preparedoesn't run when the package is installed as a dependency, so the whole pinst dance (postinstall+prepack --disable/postpack --enable) is unnecessary.So this also modernises the husky config:
.husky/pre-commitis already v9 format, so nothing else changes.Verification
yarn lint(tsc + eslint + prettier) → 0 errors (tsc confirms uuid's bundled types are sufficient).yarn vitest --run test→ 165 passed, 4 skipped.yarn install, thepreparescript set up.husky/_andcore.hooksPath; the pre-commit hook fired on this commit.Note
Independent of #391 (drop
ws). Both touch thedevDependenciesblock, so whichever merges second will need a trivial rebase.🤖 Generated with Claude Code
Summary by CodeRabbit