Skip to content

chore: remove redundant dev dependencies (@types/uuid, pinst) - #392

Open
jimmycallin wants to merge 1 commit into
mainfrom
chore/remove-redundant-devdeps
Open

chore: remove redundant dev dependencies (@types/uuid, pinst)#392
jimmycallin wants to merge 1 commit into
mainfrom
chore/remove-redundant-devdeps

Conversation

@jimmycallin

@jimmycallin jimmycallin commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Removes two devDependencies that are no longer pulling their weight.

@types/uuid

uuid v14 ships its own type declarations ("types": "./dist/index.d.ts"), so the separate @types/uuid@^11 stub is dead weight — a leftover from older uuid versions. tsc passes without it.

pinst

pinst existed only to neutralise postinstall: husky install when publishing (so consumers don't run husky). But husky is already v9, where:

  • husky install is deprecated — the command is now just husky, and
  • the recommended setup is "prepare": "husky". prepare doesn't run when the package is installed as a dependency, so the whole pinst dance (postinstall + prepack --disable / postpack --enable) is unnecessary.

So this also modernises the husky config:

- "prepack": "yarn build && pinst --disable",
+ "prepack": "yarn build",
- "postinstall": "husky install",
- "postpack": "pinst --enable"
+ "prepare": "husky"

.husky/pre-commit is already v9 format, so nothing else changes.

Verification

  • yarn lint (tsc + eslint + prettier) → 0 errors (tsc confirms uuid's bundled types are sufficient).
  • yarn vitest --run test → 165 passed, 4 skipped.
  • After yarn install, the prepare script set up .husky/_ and core.hooksPath; the pre-commit hook fired on this commit.

Note

Independent of #391 (drop ws). Both touch the devDependencies block, so whichever merges second will need a trivial rebase.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Streamlined package build and release lifecycle scripts for improved efficiency and maintainability.
    • Removed unnecessary development dependencies to reduce installation footprint and simplify the development environment.

- Drop @types/uuid: uuid v14 ships its own type declarations, so the
  separate @types stub is dead weight (tsc passes without it).
- Drop pinst and modernise the husky setup: husky is already v9, where the
  recommended hook installer is `prepare: husky`. Since `prepare` does not
  run when the package is installed as a dependency, the pinst dance
  (postinstall + prepack/postpack disable/enable) is no longer needed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e849d280-8b8e-40bf-9673-35eddd31cef7

📥 Commits

Reviewing files that changed from the base of the PR and between 60a1ffe and cdb75d1.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • ftrackhq/ftrack (manual)

📝 Walkthrough

Walkthrough

package.json lifecycle scripts are updated: prepack now runs only yarn build, prepare is added to invoke husky, and postinstall/postpack hooks are removed. The pinst and @types/uuid dev dependencies are also removed.

Changes

Lifecycle script and dependency cleanup

Layer / File(s) Summary
Script lifecycle and dev dependency updates
package.json
prepack simplified to yarn build only; prepare added to run husky; postinstall and postpack hooks removed; @types/uuid and pinst removed from devDependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing two redundant dev dependencies (@types/uuid and pinst).
Description check ✅ Passed The description is comprehensive and well-structured, explaining why each dependency is being removed and how husky config is modernized, with detailed verification steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-redundant-devdeps

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant