fix: stop frozen Connect leaking bundled Qt env into launched DCCs - #659
Merged
Conversation
A frozen (PyInstaller) ftrack Connect exports its own bundled Qt paths (QT_PLUGIN_PATH, QML2_IMPORT_PATH, PATH, loader library paths) into the environment of launched DCCs. Harmony then loads Connect's Qt 6.6 plugins in its own Qt 6.4 runtime, emitting ~10 "Plugin uses incompatible Qt library" warnings and breaking menus/dialogs. Layer 1 (root fix): the Connect launcher strips its own bundle's entries from the child environment before the launch event is published, so any studio-set Qt vars applied afterwards still win. Guarded by sys.frozen; never touches os.environ. Covers all DCCs. Layer 2 (transitional): the framework-harmony launch hook emits equivalent .set/.unset launch-env actions, protecting users on an already-installed frozen Connect that predates Layer 1. Marked for removal once the minimum supported Connect ships Layer 1. Adds Connect launcher unit tests, a Harmony qt-env-scrub suite (verified live against Harmony 27), a connect-unit-pytest CI job, and a design record under docs/specs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe change adds frozen Connect Qt-environment scrubbing, restores Linux loader paths, integrates transitional cleanup into Harmony launches, and validates behavior through unit, live-process, integration, standalone-log, and CI tests. It also lowers periodic process-monitor liveness logging from info to debug and updates its package release metadata. ChangesFrozen Qt environment cleanup
Process monitor logging update
Estimated code review effort: 5 (Critical) | ~90+ minutes Sequence Diagram(s)sequenceDiagram
participant ConnectLauncher
participant HarmonyHook
participant Harmony
participant Standalone
ConnectLauncher->>ConnectLauncher: detect frozen bundle roots
ConnectLauncher->>ConnectLauncher: scrub bundle-owned Qt paths
ConnectLauncher->>HarmonyHook: launch with cleaned environment
HarmonyHook->>Harmony: apply Qt environment actions
Harmony->>Standalone: start framework with scrubbed environment
Standalone-->>Harmony: return RPC result and logs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/push-main-test.yml:
- Around line 94-98: Add a setup step before the ftrack Connect unit tests that
installs libegl1 and any other required Qt runtime dependencies on ubuntu-22.04.
Keep the existing uv sync and uv run pytest commands in the ftrack Connect test
step unchanged.
In `@apps/connect/pyproject.toml`:
- Around line 88-91: Update the repository-level pytest configuration or generic
Python 3.13 job collection rules to exclude apps/connect/tests, while keeping
the Connect-specific pythonpath setting in tool.pytest.ini_options unchanged.
Ensure generic pytest jobs no longer collect Connect-only tests and avoid
provisioning the package outside the requested scope.
In `@docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md`:
- Line 49: Update the design record’s referenced sections to describe only
current behavior and supported-version requirements. Remove PR/release
sequencing, rollout or migration phases, historical narration such as “first
tests” or “Added,” and future follow-ups; relocate any necessary planning or
history outside this durable document.
- Around line 117-126: Rewrite the “Rejected: the standalone-side
setLibraryPaths patch” section in the design document to remove coworker, patch,
and review-history framing. Preserve the technical rationale as a current
constraint, explaining that the standalone helper’s frozen Qt and plugin
versions cannot emit these warnings and that setting library paths after
QApplication creation is too late; retain its redundancy with the existing two
layers.
In
`@projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py`:
- Around line 50-62: Update the comments surrounding the environment-scrubbing
hook to state only that it independently sanitizes the environment for
compatibility, using the locally available os/sys imports. Remove transitional,
installation-version, future-release, removal-plan, and specification references
while leaving the hook implementation unchanged.
- Around line 63-64: The fallback environment handling must scrub PATH,
LD_LIBRARY_PATH, and DYLD_LIBRARY_PATH like the launcher and restore
LD_LIBRARY_PATH_ORIG as applicable. Update the fallback logic in the discovery
hook and adjust its scoped test to verify these variables are cleared/restored
while preserving the existing Qt path behavior.
- Around line 50-67: Remove temporal rollout, release-history, and design-spec
references while preserving the current Qt environment scrub behavior. In
projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py
lines 50-67, document the current compatibility contract; in lines 374-381,
describe the scrub without referring to older installations. Remove the dated
design-spec link from
apps/connect/source/ftrack_connect/application_launcher/__init__.py lines 90-95,
make apps/connect/tests/unit/test_application_launcher_environment.py lines 4-12
self-contained, and retain the existing behavior and scope while removing
rollout/history language from
projects/framework-harmony/tests/test_qt_env_scrub.py lines 4-27.
- Around line 382-384: Update the environment merge around
get_frozen_qt_environment_actions() so scrub actions are applied first and the
existing launch_data["integration"]["env"] actions are applied afterward,
preserving configured .set, .prepend, and .append entries. Add coverage
verifying each of those existing action types remains intact when generated
scrub keys overlap.
In `@projects/framework-harmony/tests/test_qt_env_scrub.py`:
- Line 445: Replace tempfile.mktemp() with a path created under pytest-managed
tmp_path for the port file in test_qt_env_scrub.py, and apply the same change to
the related port-file setup in conftest.py. Preserve the existing filename
prefix and suffix while using tmp_path to avoid filename-claim races.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: efa3e0fb-9b2c-43a7-8dc0-eb01c95f3da6
⛔ Files ignored due to path filters (1)
projects/framework-harmony/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.github/workflows/push-main-test.ymlapps/connect/pyproject.tomlapps/connect/source/ftrack_connect/application_launcher/__init__.pyapps/connect/tests/unit/test_application_launcher_environment.pydocs/specs/2026-07-15-qt-env-leak-frozen-connect-design.mdprojects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.pyprojects/framework-harmony/tests/_launcher.pyprojects/framework-harmony/tests/test_qt_env_scrub.py
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
ftrackhq/ftrack(manual)
Comment on lines
+50
to
+62
| # --------------------------------------------------------------------------- | ||
| # TODO(remove): transitional duplicate of the ftrack Connect launcher's | ||
| # frozen-Qt scrub (apps/connect .../application_launcher/__init__.py: | ||
| # FROZEN_QT_ENVIRONMENT_VARIABLES / strip_frozen_qt_environment). It exists | ||
| # only to protect users whose *already-installed* frozen Connect predates | ||
| # that scrub: this plugin ships in a framework-harmony release that reaches | ||
| # them before the next Connect release does. Remove once the minimum | ||
| # supported Connect version ships the launcher scrub (> 26.6.x). | ||
| # | ||
| # A hook must not depend on new Connect code, so this is a self-contained | ||
| # twin (uses only the already-imported ``os``/``sys``). It is idempotent | ||
| # alongside a fixed Connect: ``.unset`` of an absent key is a no-op and | ||
| # ``.set`` rewrites the identical filtered value. Scope is intentionally |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Replace release-history commentary with a current compatibility contract.
Remove the “transitional,” prior-installation, future-release, removal-plan, and specification references. Describe only why this hook independently sanitizes the environment. As per path instructions, code must not retain migration history or depend on plans/specifications.
Also applies to: 66-67
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py`
around lines 50 - 62, Update the comments surrounding the environment-scrubbing
hook to state only that it independently sanitizes the environment for
compatibility, using the locally available os/sys imports. Remove transitional,
installation-version, future-release, removal-plan, and specification references
while leaving the hook implementation unchanged.
Source: Path instructions
Comment on lines
+50
to
+67
| # --------------------------------------------------------------------------- | ||
| # TODO(remove): transitional duplicate of the ftrack Connect launcher's | ||
| # frozen-Qt scrub (apps/connect .../application_launcher/__init__.py: | ||
| # FROZEN_QT_ENVIRONMENT_VARIABLES / strip_frozen_qt_environment). It exists | ||
| # only to protect users whose *already-installed* frozen Connect predates | ||
| # that scrub: this plugin ships in a framework-harmony release that reaches | ||
| # them before the next Connect release does. Remove once the minimum | ||
| # supported Connect version ships the launcher scrub (> 26.6.x). | ||
| # | ||
| # A hook must not depend on new Connect code, so this is a self-contained | ||
| # twin (uses only the already-imported ``os``/``sys``). It is idempotent | ||
| # alongside a fixed Connect: ``.unset`` of an absent key is a no-op and | ||
| # ``.set`` rewrites the identical filtered value. Scope is intentionally | ||
| # the four Qt path vars only (PATH / loader-path handling stays | ||
| # Connect-launcher-only, to keep this transitional surface minimal). | ||
| # | ||
| # See docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md. | ||
| # --------------------------------------------------------------------------- |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove temporal rollout and specification residue from the implementation and tests.
projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py#L50-L67: replace release/removal history and the design link with the current compatibility contract.projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py#L374-L381: describe the current scrub behavior without referring to older installations.apps/connect/source/ftrack_connect/application_launcher/__init__.py#L90-L95: remove the dated design-spec link.apps/connect/tests/unit/test_application_launcher_environment.py#L4-L12: make the module documentation self-contained.projects/framework-harmony/tests/test_qt_env_scrub.py#L4-L27: retain current behavior and test scope, removing rollout/design-history language.
As per path instructions, “Code stays locally coherent — no temporal references.”
📍 Affects 4 files
projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py#L50-L67(this comment)projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py#L374-L381apps/connect/source/ftrack_connect/application_launcher/__init__.py#L90-L95apps/connect/tests/unit/test_application_launcher_environment.py#L4-L12projects/framework-harmony/tests/test_qt_env_scrub.py#L4-L27
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py`
around lines 50 - 67, Remove temporal rollout, release-history, and design-spec
references while preserving the current Qt environment scrub behavior. In
projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py
lines 50-67, document the current compatibility contract; in lines 374-381,
describe the scrub without referring to older installations. Remove the dated
design-spec link from
apps/connect/source/ftrack_connect/application_launcher/__init__.py lines 90-95,
make apps/connect/tests/unit/test_application_launcher_environment.py lines 4-12
self-contained, and retain the existing behavior and scope while removing
rollout/history language from
projects/framework-harmony/tests/test_qt_env_scrub.py lines 4-27.
Source: Path instructions
The new apps/connect/tests broke two CI jobs: the root unit-test-pytest recursed into them and failed to import ftrack_connect, and the connect-unit-pytest job hit `libEGL.so.1` because importing the launcher runs ftrack_connect/__init__ -> qtawesome -> PySide6 (no Qt libs on the headless runner). - Add apps/connect/conftest.py that collect_ignores tests/ when ftrack_connect is not importable (find_spec, not a real import, to avoid pulling in Qt), mirroring the harmony/dcc-test-harness guards. - Load the launcher module by file path in the unit test instead of importing the package, bypassing the Qt-importing package __init__; documented in code so it is not "simplified" back. - Add release-notes entries for the frozen-Qt env scrub (connect launcher + harmony hook). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/connect/release_notes.md`:
- Line 16: Update the release-note entry describing Qt environment variables so
it explicitly states that values from the launch config or integration hook are
applied after scrubbing and override the scrubbed values; replace the ambiguous
“and win” wording without changing the surrounding behavior or guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 84c589df-fe1e-4755-8581-72d7140b1921
📒 Files selected for processing (4)
apps/connect/conftest.pyapps/connect/release_notes.mdapps/connect/tests/unit/test_application_launcher_environment.pyprojects/framework-harmony/release_notes.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
ftrackhq/ftrack(manual)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/connect/tests/unit/test_application_launcher_environment.py
Address CodeRabbit review on PR #659: - Merge frozen-Qt scrub actions before any env actions already configured on the integration, so a studio's own QT_PLUGIN_PATH.set/.prepend/.append runs after the scrub and takes precedence (was silently overwritten). - Replace tempfile.mktemp() with pytest tmp_path / tmp_path_factory in the standalone port-file fixtures to avoid a filename-claim race. - Clarify release-note precedence wording ("take precedence"). - Rewrite the design doc and code comments to current-state only (drop PR/rollout/review-history narration; rejected alt -> "Not used", follow-ups -> "Scope boundaries"); keep a concise TODO(remove) marker. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/connect/tests/unit/test_application_launcher_environment.py (1)
1-57: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover bundle-root detection in addition to path stripping.
These tests inject
bundle_roots, so they exercise filtering but notget_frozen_bundle_roots()—the production path that derives_MEIPASSand adds the macOS.approot. Add frozen/non-frozen and macOS-root tests unless another test module already covers this helper.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/connect/tests/unit/test_application_launcher_environment.py` around lines 1 - 57, Extend the tests in this module to cover get_frozen_bundle_roots(), including non-frozen behavior, frozen _MEIPASS detection, and macOS .app bundle-root derivation. Reuse the existing direct module-loading setup and monkeypatch the relevant runtime/platform values; avoid duplicating coverage if an existing test module already exercises this helper.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md`:
- Around line 48-49: Update
docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md lines 48-49 to
describe the launcher scrub and Harmony hook implementations and their
compatibility relationship without release sequencing; lines 113-115 to state
when the hook is currently required, removing the future minimum-version
condition and TODO(remove); and lines 130-132 to describe DCC behavior without
temporal wording. Update projects/framework-harmony/release_notes.md line 20 to
describe current support for frozen Connect installations without launcher
scrubbing, removing “now,” “Transitional shim,” and “predating.”
---
Nitpick comments:
In `@apps/connect/tests/unit/test_application_launcher_environment.py`:
- Around line 1-57: Extend the tests in this module to cover
get_frozen_bundle_roots(), including non-frozen behavior, frozen _MEIPASS
detection, and macOS .app bundle-root derivation. Reuse the existing direct
module-loading setup and monkeypatch the relevant runtime/platform values; avoid
duplicating coverage if an existing test module already exercises this helper.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8293acfd-835c-4e31-a3a7-d4a2145ba3aa
📒 Files selected for processing (8)
apps/connect/release_notes.mdapps/connect/source/ftrack_connect/application_launcher/__init__.pyapps/connect/tests/unit/test_application_launcher_environment.pydocs/specs/2026-07-15-qt-env-leak-frozen-connect-design.mdprojects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.pyprojects/framework-harmony/release_notes.mdprojects/framework-harmony/tests/conftest.pyprojects/framework-harmony/tests/test_qt_env_scrub.py
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
ftrackhq/ftrack(manual)
💤 Files with no reviewable changes (1)
- apps/connect/source/ftrack_connect/application_launcher/init.py
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/connect/release_notes.md
- projects/framework-harmony/connect-plugin/hook/discover_ftrack_framework_harmony.py
Comment on lines
+48
to
+49
| The launcher scrub and the Harmony hook ship on independent release | ||
| vehicles (ftrack Connect and the framework-harmony plugin). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep durable documentation current-state only.
These entries mix current behavior with release sequencing, future removal plans, or temporal wording. Preserve the technical compatibility behavior, but remove the rollout narrative.
docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md#L48-L49: describe the two implementations and their compatibility relationship without “release vehicles”.docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md#L113-L115: remove the future minimum-version condition andTODO(remove); state when the hook is currently required.docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md#L130-L132: remove “today” and describe the DCC behavior timelessly.projects/framework-harmony/release_notes.md#L20-L20: remove “now”, “Transitional shim”, and “predating”; describe current support for frozen Connect installations without launcher scrubbing.
As per path instructions, implementation documentation must stand on its own without PR, release, migration, historical, or future-work framing.
📍 Affects 2 files
docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md#L48-L49(this comment)docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md#L113-L115docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md#L130-L132projects/framework-harmony/release_notes.md#L20-L20
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md` around lines 48 -
49, Update docs/specs/2026-07-15-qt-env-leak-frozen-connect-design.md lines
48-49 to describe the launcher scrub and Harmony hook implementations and their
compatibility relationship without release sequencing; lines 113-115 to state
when the hook is currently required, removing the future minimum-version
condition and TODO(remove); and lines 130-132 to describe DCC behavior without
temporal wording. Update projects/framework-harmony/release_notes.md line 20 to
describe current support for frozen Connect installations without launcher
scrubbing, removing “now,” “Transitional shim,” and “predating.”
Source: Path instructions
The watchdog's periodic "Checking if application is still alive (pid: ...)" message fired on every poll at info level, flooding the logs. Drop it to debug; the process-detected and process-gone messages stay at info so it's still clear when the watchdog launched and when it fired. Bump ftrack-utils to 4.0.1 and refresh the affected lockfiles. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hdd
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves : no dedicated ticket found for this bug — add an
FT-/F-link here if one exists.This PR has been tested on :
Overview
Purpose: Stop a frozen (PyInstaller) ftrack Connect from leaking its own bundled Qt paths into the environment of launched DCCs. Harmony 25.2/27 (Qt 6.4) otherwise loads Connect's bundled Qt 6.6 plugins, printing ~10
Plugin uses incompatible Qt library (6.6.0)warnings and breaking menus/dialogs.Scope:
apps/connectlauncher (root fix, all DCCs) and theframework-harmonylaunch hook (transitional fix), plus tests, a CI job, and a design record.Implementation Details
Approach: Two layers. Layer 1 — the Connect launcher (
_get_application_environment) strips its own bundle's entries fromQT_PLUGIN_PATH/QML(2)_IMPORT_PATH/PATH/loader-library paths before the launch event is published, so any studio-set Qt vars applied afterwards still win; guarded bysys.frozenand never touchingos.environ. Layer 2 — the Harmony hook emits equivalent.set/.unsetlaunch-env actions so users on an already-installed frozen Connect (predating Layer 1) are protected immediately by the next plugin release.Reasoning: The two layers ship on different release vehicles (Connect vs. the framework-harmony plugin); Layer 2 reaches existing installs now, Layer 1 fixes it at the source for every DCC. A previously-proposed
setLibraryPaths()patch in the standalone process was rejected (wrong process; runs too late) — see the design record.Changes: New pure helpers
get_frozen_bundle_roots/strip_frozen_qt_environment/restore_loader_library_pathin the connect launcher;get_frozen_qt_environment_actions(self-contained twin, markedTODO(remove)) wired into the Harmony hook'son_launch_integration.Trade-offs: Layer 2 duplicates Layer 1's logic deliberately (hooks must not depend on new Connect code); the duplicate is idempotent alongside a fixed Connect and is scheduled for removal once the minimum supported Connect ships Layer 1 (> 26.6.x).
Testing
Tests Added: First unit tests in
apps/connect(tests/unit/test_application_launcher_environment.py) covering the frozen-path scrub; aframework-harmonytests/test_qt_env_scrub.pysuite (unit action-emission + live tier-1 launch verification viaps eww+ tier-2 standalone log check); aconnect-unit-pytestCI job mirroringharness-unit-pytest.Manual Testing: Reproduced on this workstation — launching Harmony 25.2 with
QT_PLUGIN_PATH= Connect's bundled Qt gave 32incompatible Qt library (6.6.0)lines; with it unset (the scrubbed state) → 0. The Harmony test suite (incl. the live tier-1/tier-2 cases and the existingtest_launch.py) passed against real Harmony 27. To verify against the frozen Connect: restartFtrack Connect.app, launch Harmony, thenps eww $(pgrep -f "Harmony 25.2 Premium.app/Contents/MacOS") | grep -oE "QT_PLUGIN_PATH|QML2_IMPORT_PATH"→ expect no output.Testing Environment: macOS (Harmony 25.2 + 27, installed frozen
Ftrack Connect.app).Notes for Reviewers
Focus Areas: The env-scrub prefix-matching (
normcase/normpath, sibling-collision guard, macOS two-root.appcase) and its placement before the launch-event publish so studio overrides still win.Dependencies: None. Layer 1 ships with the next Connect release; Layer 2 with the next framework-harmony plugin release.
Known Issues: Release notes and user-facing docs are not yet updated (checkboxes left unchecked). On macOS the DCC's stderr never reaches ftrack's log files, so these warnings were only visible on Windows / via direct stderr capture; the meaningful macOS check is the
ps ewwenv inspection above. Windows/Linux end-to-end verification is still pending.Summary by CodeRabbit