Add optional --calendar-name filter to calendar-events command - #27
Open
gklei wants to merge 3 commits into
Open
Add optional --calendar-name filter to calendar-events command#27gklei wants to merge 3 commits into
gklei wants to merge 3 commits into
Conversation
gklei
marked this pull request as ready for review
May 12, 2026 17:33
kaiju
requested changes
May 20, 2026
| @cli.command("calendar-events", short_help="Return Apple calendar events") | ||
| @time_range | ||
| @click.option( | ||
| "--calendar-name", type=str, default=None, help="Which calendar to retrieve events for by calendar name" |
Contributor
There was a problem hiding this comment.
Maybe "Return events matching calendar name."
Contributor
Author
There was a problem hiding this comment.
That's much better! Updated.
Contributor
|
Do we want to return nothing if no calendars match? |
Contributor
Author
That's a good question, probably not. Should we return some type of output like "No calendars found with name: X"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
--calendar-nameclick option tocalendar-eventscommand.If it's present:
calendar_nameto match the value from the command line optioncalendar_idsfrom the filtered set of calendars will be passed through to theFulcraAPI.calendar_events()call