Add group functionality to the API and CLI. by unsynchronized · Pull Request #71 · fulcradynamics/fulcra-api-python

unsynchronized · 2026-07-29T06:27:42Z

No description provided.

- update CLI group commands to warn about specific properties

lancelets

Awesome! I know the existing query command work is in progress; just took a look at the pool commands and made some comments, mostly for my own curiosity.

lancelets · 2026-07-30T17:14:19Z

+        raise click.ClickException(
+            f"Invalid {option_name} format: {value}. Use ISO8601 format."
+        )
+


Just wondering whether these are general enough to put in utils.py.

Good call, doing it

lancelets · 2026-07-30T19:20:09Z

+@click.option("--header-image-url", help="URL of the group's header image")
+@click.option("--preview-image-url", help="URL of the group's preview image")
+@click.option("--annotations", help="Additional group annotations (JSON object)")
+@click.option("--view-description", help="Description of the group's view (JSON object)")


I know we'll want to add more help about how to define the report view, but there's definitely more infrastructure to set up to generate reports for custom pools first.

Yeah, definitely - I'm working on adding it to the docs too, but we'll want these in there eventually, so I added them now.

Worst case is someone tries it and it doesn't work, in which case we can fix it and get a new group user!

lancelets · 2026-07-30T19:54:31Z

+        --description "A month-long step challenge." \\
+        --data-type StepCount --url https://example.com/challenge
+    """
+    # Validate data types against catalog


I drafted a valid_shared_types utility function in the open file sharing PR, and this made me wonder about using that here in future, and whether we want to support file sharing to groups.

https://github.com/fulcradynamics/fulcra-api-python/pull/72/changes#diff-1e87d9b275bfac4b4f914ce86ff38ea6d499b33a84398596e37816c0c4511a90

Oooh okay, yeah, let's use that instead once that merges. (Actually we should fix the catalog too, adding that to the list)

The valid_shared_types is now merged, though I think we'd need to add apple_workouts to it's list of temporary_allowed_types (and perhaps remove calendars and calendar_events since they are now in the catalog). I'm not sure if that is worth doing in this PR, though.

lancelets

LGTM—Thank you!

…ill using an alternate accessor, but we explicitly use a call to a new function `resolve_data_source` to look at the `group_id` and `participant_id` parameters. If those are present, it uses a group accessor; otherwise it uses the non-group one. - Add CLI errors to make it clear that you can't use `--user-id` and `--group-id` / `--participant-id` at the same time - Simplify query paths a bit in get_records - Bake in `apple_workouts`, `calendars`, and `calendar_events` for now but eventually this goes in the catalog (it's on my list)

…sed, probably through v1

gklei

Nice! Had one question about the --view-description option in the update command that Leif and I noticed. Looks great overall!

gklei · 2026-08-13T14:38:32Z

+)
+@click.option(
+    "--view-description", help="New description of the group's view (JSON object)"
+)


Wondering if the --view-description options option should be removed from the update command if we are leaving it out of the create command in this first pass. Definitely seems fine either way; I like the idea of being able to set it somehow, just wasn't sure if this was still intended in this pass.

lancelets

LGTM—Awesome!

lancelets · 2026-08-13T17:36:36Z

+    return f
+
+
+def resolve_data_source(fulcra_api: FulcraAPI, group_id, participant_id):


Greg and I talked about how Zed seems to understand the return type of this function without a type hint; just wondering if we want to add -> FulcraAPI | FulcraGroupParticipant for clarity.

lancelets · 2026-08-13T17:42:16Z

+        --description "A month-long step challenge." \\
+        --data-type StepCount --url https://example.com/challenge
+    """
+    # Validate data types against catalog


The valid_shared_types is now merged, though I think we'd need to add apple_workouts to it's list of temporary_allowed_types (and perhaps remove calendars and calendar_events since they are now in the catalog). I'm not sure if that is worth doing in this PR, though.

kaiju · 2026-08-25T13:32:11Z

+from .utils import parse_iso_time, parse_json_object, pass_fulcra_api, requires_auth
+
+
+@click.group(help="Data group management sub-commands")


Maybe we should put some high level overview description of the functionality in the help text for the group subcommand

unsynchronized added 3 commits July 28, 2026 23:27

initial. Lightly edited slop descriptions though

9763773

initial crack at adding accessors for group participants

dcab95f

update this

b4a7efd

unsynchronized marked this pull request as ready for review July 30, 2026 04:36

unsynchronized added 2 commits July 30, 2026 12:33

- add a test for groups

b9fbda3

- update CLI group commands to warn about specific properties

examples

803d816

unsynchronized requested a review from kaiju July 30, 2026 19:43

lancelets reviewed Jul 30, 2026

View reviewed changes

Add an allow-list for fields in there for future compat

ae7b564

lancelets previously approved these changes Jul 31, 2026

View reviewed changes

unsynchronized added 6 commits July 31, 2026 17:12

factor out time format checks

bc20032

Take out annotations and view_description from group creation right now.

3cc44d6

take calendars out for now until we work out how they should be acces…

ed6dd2d

…sed, probably through v1

no, really, use a time zone

1d5a13d

simpler descriptions

2809197

unsynchronized dismissed lancelets’s stale review via 2809197 August 4, 2026 15:01

unsynchronized added 4 commits August 11, 2026 17:34

Merge branch 'main' into group-functions

2712b64

Don't expose public groups here yet

d010a5c

more tz enforcement

f6530c5

update this

08edbe9

unsynchronized mentioned this pull request Aug 12, 2026

group management fulcradynamics/fulcra-context-mcp#15

Open

gklei approved these changes Aug 13, 2026

View reviewed changes

This comment was marked as duplicate.

Sign in to view

lancelets approved these changes Aug 13, 2026

View reviewed changes

kaiju reviewed Aug 25, 2026

View reviewed changes

Merge branch 'main' into group-functions

8a3bddb

		return f


		def resolve_data_source(fulcra_api: FulcraAPI, group_id, participant_id):

		from .utils import parse_iso_time, parse_json_object, pass_fulcra_api, requires_auth


		@click.group(help="Data group management sub-commands")

Uh oh!

Conversation

unsynchronized commented Jul 29, 2026

Uh oh!

lancelets left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lancelets left a comment

Choose a reason for hiding this comment

Uh oh!

gklei left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

lancelets left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants