chore(#7019): drop the last "interim" and rewrap two comments - #7032
chore(#7019): drop the last "interim" and rewrap two comments#7032waynesun09 wants to merge 1 commit into
Conversation
Addresses the review-agent findings on bedf185 that were still open. pi_run.go's `-e` block still called it "the interim Claude-on-Vertex provider". Removing that word from the extension's characterization is what #7019 is for, and the sweep covered pi.go, the Containerfile and the docs but missed this one. It is now "the vendored Claude-on-Vertex extension". fullsend-agent.js's childEnv comment was left at 98 columns by the earlier rewrite of its stray-credential rationale, in a file that wraps at 79. Rewrapped at the sentence boundary; no wording change. The review's third finding, [protected-path] on images/README.md and images/sandbox/Containerfile, is informational -- it asks for human approval of protected-path changes, which the PR has. Its second [comment-formatting] finding, pi_run.go:25 at 104 columns, no longer applies: that comment was rewritten in 4cc8e34 for the 0.85.0 bump and now wraps within the file's convention. Assisted-by: Claude (fix) Signed-off-by: Wayne Sun <gsun@redhat.com>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each action level your way: inline, summary, both, or drop |
PR Summary by QodoClarify vendored Vertex extension comments and restore line wrapping
AI Description
High-Level Assessment
Files changed (2)
|
|
🤖 Finished Review · ✅ Success · Started 10:51 PM UTC · Completed 11:02 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.97 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: low (1/5) DetailsMinimal cosmetic comment changes to two files with 6 total line edits, no protected paths, no test impact, established author, addressing review feedback on a closed issue. |
|
Looks good to me |
Summary
The two review-agent findings on #7025 that were still open when it reached the merge queue. Both are comments only — no behaviour change, 3 lines.
internal/runtime/pi_run.go— the-eblock still called it "The interim Claude-on-Vertex provider". Dropping "interim" from the extension's characterization is what #7019 was for; that sweep coveredpi.go, the Containerfile andruntime-implementation.mdbut missed this one. Now "The vendored Claude-on-Vertex extension".internal/runtime/pi_extension/fullsend-agent.js— thechildEnvcomment was left at 98 columns by #7025's rewrite of its stray-credential rationale, in a file that wraps at 79. Rewrapped at the sentence boundary; wording unchanged.Why these came separately
They were found by
fullsend-ai-review[bot]on an earlier head of #7025 and confirmed still open against the final one. By then #7025 was enqueued and its branch was locked (protected branch hook declined), and it hadbehaviour+e2egreen — so pushing a two-comment fix would have thrown away a full CI cycle for cosmetics. The change request was dismissed as "cosmetic, carried in a follow-up" and both threads resolved with that pointer; this is that follow-up.The same review's other two findings needed no change:
[protected-path]onimages/is informational and satisfied by the human approval on #7025, and[comment-formatting]onpi_run.go:25was superseded when that comment was rewritten for the pi 0.85.0 bump.Testing
Follow-up to #7025.