docs(#7039): correct Vertex alias resolution in pinned-binaries table - #7040
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#7039): correct Vertex alias resolution in pinned-binaries table#7040fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The Re-check on bump cell for Claude Code in the pinned-binaries
table incorrectly stated that ANTHROPIC_DEFAULT_*_MODEL does not
steer alias resolution on Vertex. A/B runs on Claude Code 2.1.258
(agents#1181) confirmed that the env variable does steer both the
main model and sub-agent aliases.
Rewrite the cell to document the verified behavior: on Vertex,
opus/sonnet/haiku resolve from the CLI default table steered by
ANTHROPIC_DEFAULT_{OPUS,SONNET,HAIKU}_MODEL; the fleet sets the
sonnet pin in env/gcp-vertex.env; per-repo models.aliases remaps
only the parent --model and sub-agents follow the env variable
until #7031 makes persona models runner-resolved.
Note: pre-commit hooks were not run. pre-commit could not complete
(infrastructure failure). Applicable hooks (trailing-whitespace,
end-of-file-fixer, lint-docs-links, lychee link check) were run
directly and passed.
Closes #7039
|
🤖 Finished Review · ✅ Success · Started 2:57 AM UTC · Completed 3:12 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.77 |
Site previewPreview: https://ce7936e1-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsTrivial 1-file, 2-line documentation correction by a bot with no protected paths, security-sensitive files, or dependency changes; elevated from 1 to 2 by Tier 2 git history signals showing the target file is in an active area with 48 commits in 30 days, 6 concurrent authors, and 38 fix-related commits in 90 days. |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the "Re-check on bump" cell for Claude Code in the pinned-binaries table (
docs/contributing/runtime-implementation.md). The cell incorrectly stated thatANTHROPIC_DEFAULT_*_MODELdoes not steer alias resolution on Vertex; A/B testing on Claude Code 2.1.258 confirmed it does.Changes
opus/sonnet/haikuresolve from the running CLI's default table, whichANTHROPIC_DEFAULT_{OPUS,SONNET,HAIKU}_MODELsteers for the main model and sub-agentsenv/gcp-vertex.envmodels.aliasesremaps only the parent--model; sub-agents follow the env variable until sub-agents: per-persona model configuration (agents[].subagents), resolved by the runner, dispatched bysubagent_type#7031Testing
models.aliasesscope claim againstdocs/runtimes/claude.mdlycheeoffline link check passed (all links valid)lint-docs-linkspassedCloses #7039
Post-script verification
agent/7039-fix-vertex-alias-docs)6d496c4ce54bcccefdcbd5bec1ab44f775a33de8..HEAD)