test(#7058): cover harness dispatch on macOS

[shairevivo]

Summary

Canonicalize the base-composition test workspace on macOS so the /var to
/private/var alias does not falsely trigger the production containment check.
Extend the existing Darwin job to cover harness dispatch tests.

Related Issue

Fixes #7058

Changes

• resolve the temporary test directory through symlinks before composing paths
• run internal/harnessdispatch tests in the existing Darwin CI job

Testing

• make lint passes (stage changes first, then run)
• go test -race ./internal/harnessdispatch/... -count=1
• Tests added/updated for new or modified logic

Checklist

• PR title follows Conventional Commits
• Commits are signed off (DCO)
• I wrote this contribution myself and can explain all changes in it

[github-actions]

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-code-review]

PR Summary by Qodo

Cover harness dispatch tests on macOS

🧪 Tests ⚙️ Configuration changes 🕐 Less than 10 minutes

AI Description

• Canonicalizes temporary composition workspaces to handle macOS /var symlink aliases.
• Runs harness-dispatch race tests in the existing Darwin CI job.

Diagram

graph TD
  CI["Darwin CI"] --> Race["Race Test Runner"] --> Sandbox["Sandbox Tests"]
  Race --> Harness["Harness Tests"] --> Base["Base Composition"] --> Canon["Canonical Workspace"]

Loading

High-Level Assessment

The current approach is appropriate: resolving the temporary directory with filepath.EvalSymlinks models the canonical paths used by containment checks and remains cross-platform. macOS-specific string rewriting or skipping the test on Darwin would be more brittle and reduce coverage.

Files changed (2) +3 / -1

Tests (1) +2 / -0

enumerate_test.goCanonicalize the composition test workspace +2/-0

Canonicalize the composition test workspace

• Resolves the temporary test directory through symlinks before constructing harness paths. This prevents macOS '/var' and '/private/var' aliases from falsely failing production containment validation.

internal/harnessdispatch/enumerate_test.go

Other (1) +1 / -1

lint.ymlRun harness-dispatch tests in Darwin CI +1/-1

Run harness-dispatch tests in Darwin CI

• Extends the existing macOS race-test command to include all 'internal/harnessdispatch' packages alongside the sandbox suite.

.github/workflows/lint.yml

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/harness/compose.go	81.81%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!