Add auto update support for containers#93
Open
Andrew-Pohl wants to merge 9 commits into
Open
Conversation
Andrew-Pohl
changed the title
Member
Author
|
@leonprou good to go now are you able to do your magic and make checkForUpdates.sh executable by default? (not sure how you did that last time) |
ArseniiPetrovich
requested changes
Mar 1, 2021
ArseniiPetrovich
left a comment
ArseniiPetrovich
left a comment
There was a problem hiding this comment.
The script is good, but I have some concern about it's stability. Some of them are minor and some are not. Please, check my comments below.
Member
Author
|
@ArseniiPetrovich thanks for the comments will push some changes tonight :) |
The script compares currently running containers with the latest versions from github if new version are available it will rerun the quickstart script
stupid windows
Member
Author
|
Ok made @ArseniiPetrovich suggested changes also rebased onto master and fixed some conflicts |
ArseniiPetrovich
approved these changes
Mar 4, 2021
ArseniiPetrovich
left a comment
ArseniiPetrovich
left a comment
There was a problem hiding this comment.
Okay, now it looks good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.