Skip to content

feat: allow minimumReleaseAgeExclude with fylein packages#15

Merged
rvab merged 5 commits into
masterfrom
allow_min_release_exlcude_for_fylein_packages
Jul 3, 2026
Merged

feat: allow minimumReleaseAgeExclude with fylein packages#15
rvab merged 5 commits into
masterfrom
allow_min_release_exlcude_for_fylein_packages

Conversation

@rvab

@rvab rvab commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a reusable Python-based validator for pnpm-workspace.yaml policy settings (including scoped support for minimumReleaseAgeExclude) and wires it into the existing GitHub Actions workflow, with accompanying fixtures and tests.

Changes:

  • Added scripts/validate_pnpm_workspace.py to validate pnpm-workspace.yaml structure and policy constraints, including minimumReleaseAgeExclude entries scoped to @fylein/* and @fylein/<package>.
  • Added unit + CLI end-to-end tests with YAML fixtures to verify validator behavior.
  • Updated the validate-pnpm-config.yml workflow to run the shared validator script from the fylein/workflows repository and documented local test execution in the README.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
scripts/validate_pnpm_workspace.py New validator script implementing policy checks for pnpm-workspace.yaml.
.github/workflows/validate-pnpm-config.yml Switches workflow from inline Python to a checked-out shared validator script.
tests/test_validate_pnpm_workspace.py Unit tests for validator functions and error reporting.
tests/test_validate_pnpm_workspace_e2e.py End-to-end tests running the validator CLI against fixtures.
tests/fixtures/pnpm-workspace.valid.yaml Valid fixture covering minimumReleaseAgeExclude with @fylein/* and a concrete package.
tests/fixtures/pnpm-workspace.invalid-exclude.yaml Invalid fixture ensuring non-@fylein/* entries are rejected.
tests/fixtures/pnpm-workspace.invalid-yaml.yaml Invalid YAML fixture ensuring YAML parsing errors are surfaced.
README.md Documents validator purpose and how to run tests locally.
.gitignore Ignores common Python local artifacts (.venv/, __pycache__/, *.pyc).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_validate_pnpm_workspace.py
Comment thread scripts/validate_pnpm_workspace.py
shell: bash
env:
WORKFLOW_REF: ${{ github.workflow_ref }}
WORKFLOWS_FALLBACK_REF: allow_min_release_exlcude_for_fylein_packages
Comment thread README.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@rvab rvab merged commit 2445a79 into master Jul 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants