feat: allow minimumReleaseAgeExclude with fylein packages#15
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a reusable Python-based validator for pnpm-workspace.yaml policy settings (including scoped support for minimumReleaseAgeExclude) and wires it into the existing GitHub Actions workflow, with accompanying fixtures and tests.
Changes:
- Added
scripts/validate_pnpm_workspace.pyto validatepnpm-workspace.yamlstructure and policy constraints, includingminimumReleaseAgeExcludeentries scoped to@fylein/*and@fylein/<package>. - Added unit + CLI end-to-end tests with YAML fixtures to verify validator behavior.
- Updated the
validate-pnpm-config.ymlworkflow to run the shared validator script from thefylein/workflowsrepository and documented local test execution in the README.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/validate_pnpm_workspace.py |
New validator script implementing policy checks for pnpm-workspace.yaml. |
.github/workflows/validate-pnpm-config.yml |
Switches workflow from inline Python to a checked-out shared validator script. |
tests/test_validate_pnpm_workspace.py |
Unit tests for validator functions and error reporting. |
tests/test_validate_pnpm_workspace_e2e.py |
End-to-end tests running the validator CLI against fixtures. |
tests/fixtures/pnpm-workspace.valid.yaml |
Valid fixture covering minimumReleaseAgeExclude with @fylein/* and a concrete package. |
tests/fixtures/pnpm-workspace.invalid-exclude.yaml |
Invalid fixture ensuring non-@fylein/* entries are rejected. |
tests/fixtures/pnpm-workspace.invalid-yaml.yaml |
Invalid YAML fixture ensuring YAML parsing errors are surfaced. |
README.md |
Documents validator purpose and how to run tests locally. |
.gitignore |
Ignores common Python local artifacts (.venv/, __pycache__/, *.pyc). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| shell: bash | ||
| env: | ||
| WORKFLOW_REF: ${{ github.workflow_ref }} | ||
| WORKFLOWS_FALLBACK_REF: allow_min_release_exlcude_for_fylein_packages |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Aniruddha-Shriwant
approved these changes
Jul 1, 2026
hlkavya0213
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.