Fix --daemon flag being silently dropped in webless mode

[gkr0110]

Summary

scripts/pulsar forwards "$@" to the underlying command for every launch mode (gunicorn, uwsgi, chaussette, circusd, paster) except webless, where the arguments are dropped entirely. As a result, pulsar --mode webless --daemon silently starts pulsar-main in the foreground, attached to the caller's shell, instead of daemonizing it. No error is raised, so this is easy to miss — the process looks like it started fine until the terminal session closes and it dies with it.

This came up while standing up a webless/AMQP-driven Pulsar deployment talking to a RabbitMQ broker: the AMQP consumers bound and started heartbeating correctly, but the process wasn't actually backgrounded despite --daemon being passed.

Root cause

elif [ "$MODE" == "webless" ]; then
    if hash pulsar-main 2>/dev/null; then
        echo "Starting pulsar with command [pulsar-main]"
        pulsar-main          # <-- "$@" never referenced
    else
        ...
        python pulsar/main.py    # <-- same here
    fi

Compare to every other branch, e.g. gunicorn mode:

elif [ "$MODE" == "gunicorn" ]; then
    echo "Starting pulsar with command [pulsar-serve \"$PULSAR_CONFIG_FILE\" \"$@\"]"
    pulsar-serve "$PULSAR_CONFIG_FILE" "$@"

Simply adding "$@" to the webless branch isn't quite enough on its own, though, because pulsar-main doesn't share pulsar-serve's flag names:

	pulsar-serve (gunicorn)	pulsar-main (webless)
Daemonize	--daemon	-d / --daemonize
Stop a running daemon	--stop-daemon	(not implemented)

Testing

Manually tested against a live webless deployment connecting to RabbitMQ over AMQPS (password auth, TLS via amqp_connect_ssl_ca_certs):

• pulsar --mode webless --daemon now correctly forks into the background and writes to the expected log file, instead of staying attached to the invoking shell.
• bash -n scripts/pulsar passes.
• Confirmed via ps/process inspection that the daemonized process survives the originating SSH session closing.

Related

None found — searched existing issues/PRs for webless + daemon without a match before opening this.

[gkr0110]

@jmchilton - Could you please review this PR?

[gkr0110]

@mvdbeek - removed the comments as you suggested, could you please review and merge if it's good?