Let administrators choose the background map - #54
Merged
Conversation
trasher
force-pushed
the
feature/tilesprefs
branch
from
September 2, 2026 09:20
7e7640e to
6c6b5d3
Compare
trasher
marked this pull request as ready for review
September 2, 2026 09:20
A settings page now offers every provider documented in README.tiles.md,
plus one's own address, attribution, maximum zoom and subdomains.
Settings live in Galette preferences under pref_maps_tiles_*, so the plugin
needs no table of its own and no database version bump.
The address is stored as a string rather than a URL. Galette's URL validation
rejects a host starting with a brace, which would turn away the {s} subdomain
form the OSM-FR and Humanitarian providers rely on.
trasher
force-pushed
the
feature/tilesprefs
branch
from
September 2, 2026 10:50
6c6b5d3 to
8a8c2da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the CARTO URL with OpenFreeMap only moved the hardcoding. The OSMF tile usage policy asks the opposite outright: avoid hard-coding the tile URL, allow switching without a software update. A settings page now offers every provider documented in README.tiles.md, plus one's own address, attribution, maximum zoom and subdomains.
Settings live in Galette preferences under pref_maps_tiles_*, so the plugin needs no table of its own and no database version bump. The provider list stays here rather than in the core schema: tile URLs die, and retiring one has to be a plugin release.
The address is stored as a string rather than a URL. Galette's URL validation rejects a host starting with a brace, which would turn away the {s} subdomain form the OSM-FR and Humanitarian providers rely on.
The raster path no longer pays for MapLibre: the megabyte of GL bundle is requested only when the chosen background is vector. Browsers without WebGL 2 still fall back to raster OpenStreetMap, now taken from the provider list rather than written out again.
Requires galette/galette#952