Rewrite IsAspherical - #158
Conversation
... to use higher level polymaking interfaces; this makes it more robust (e.g. it catches and reports errors, unlike `Exec`), and also compatible with future improvements to polymaking.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 43.84% 43.82% -0.02%
==========================================
Files 364 364
Lines 66466 66443 -23
==========================================
- Hits 29141 29118 -23
Misses 37325 37325
🚀 New features to boost your workflow:
|
|
@grahamknockillaree I hope this is OK for you. Having this in HAP would make it much easier to make some major improvements to the polymaking package :-) |
|
Thanks @grahamknockillaree for merging. Would you terribly mind making a release with this? By the way, did I ever tell you about our release action that makes making a release easier than with the old ReleaseTools? Basically, you have to update the package version and date in PackageInfo.g and commit & push that go git; and then press a button on GitHub... There is ed details, step-by-step guide with screenshots here: https://github.com/gap-actions/release-pkg (the action has already been set up on this repository). |
|
Done!
Graham
…________________________________
From: Max Horn ***@***.***>
Sent: Saturday, August 29, 2026 3:45 PM
To: gap-packages/hap ***@***.***>
Cc: Ellis, Graham J. ***@***.***>; Mention ***@***.***>
Subject: Re: [gap-packages/hap] Rewrite IsAspherical (PR #158)
External Email: This email originated outside the University of Galway. Do not open attachments or click on links unless you believe the content is safe.
Ríomhphost Seachtrach: Níor tháinig an ríomhphost seo ó Ollscoil na Gaillimhe. Ná hoscail ceangaltáin agus ná cliceáil ar naisc mura gcreideann tú go bhfuil an t-ábhar sábháilte.
[https://avatars.githubusercontent.com/u/241512?s=20&v=4]fingolfin left a comment (gap-packages/hap#158)<#158 (comment)>
Thanks @grahamknockillaree<https://github.com/grahamknockillaree> for merging. Would you terribly mind making a release with this?
By the way, did I ever tell you about our release action that makes making a release easier than with the old ReleaseTools? Basically, you have to update the package version and date in PackageInfo.g and commit & push that go git; and then press a button on GitHub... There is ed details, step-by-step guide with screenshots here: https://github.com/gap-actions/release-pkg (the action has already been set up on this repository).
—
Reply to this email directly, view it on GitHub<#158?email_source=notifications&email_token=AHGCWP3QTW3ZAOR76AAW3F35MLT7HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBWGMYDIMRUGM32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5463042437>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHGCWPY57246TFSIGSC64HL5MLT7HAVCNFSNUABFKJSXA33TNF2G64TZHMYTMOBVGM4TCNJQHNEXG43VMU5TKMJYGE2DMNRZGYY2C5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AHGCWP2M7RO3ARQBUXKW3WL5MLT7HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBWGMYDIMRUGM32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android<https://github.com/notifications/mobile/android/AHGCWPZ7FVNA4AFM3TJES7T5MLT7HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBWGMYDIMRUGM32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
... to use higher level polymaking interfaces; this makes it more
robust (e.g. it catches and reports errors, unlike
Exec), andalso compatible with future improvements to polymaking.