Skip to content

fix: return 404 when receiving unknown id #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbgap merged 1 commit into from
Jul 21, 2026
Merged

fix: return 404 when receiving unknown id #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions alerta/views/notification_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ def get_notification_rule(notification_rule_id):
@jsonp
def get_notification_rule_history(notification_rule_id):
notification_rule = NotificationRule.find_by_id(notification_rule_id)
total = notification_rule.history_count()
paging = Page.from_params(request.args, total)
if notification_rule:
total = notification_rule.history_count()
paging = Page.from_params(request.args, total)
notification_rule_history = [h.serialize for h in notification_rule.get_notification_rule_history(page=paging.page, page_size=paging.page_size)]
return jsonify(
status='ok',
Expand Down
Loading