Adapt VPA resources to explicitly specify update mode 'InPlaceOrRecreate' - #100
Merged
gardener-prow[bot] merged 1 commit intoJul 24, 2026
Conversation
gardener-prow
Bot
added
do-not-merge/needs-kind
|
I reviewed this and it appears okay. Consider it approved. |
52 tasks
shreyas-s-rao
approved these changes
Jul 24, 2026
|
LGTM label has been added. DetailsGit tree hash: 1234133633b4c55af7763848f5ab34a3b31fe7ba |
gardener-prow
Bot
added
the
approved
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shreyas-s-rao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/kind enhancement |
gardener-prow
Bot
added
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Gardener's
VPAInPlaceUpdatesfeature gate has been promoted and unconditionally enabled. This unconditionally enables the Gardener ResourceManager's
vpa-in-place-updatesadmission webhook, which was previously mutating the value fromRecreatetoInPlaceOrRecreateat admissiontime. This change makes the extension explicitly set the correct value, aligning the code with the actual runtime behavior and removing the implicit
dependency on the webhook mutation.
Which issue(s) this PR fixes:
Part of gardener/gardener#12955
Special notes for your reviewer:
N/A
Release note: