combined adjustable + mergeable submissions - #482
Open
ckoopmann wants to merge 1 commit into
Open
Conversation
ckoopmann
marked this pull request as ready for review
August 20, 2026 08:26
ckoopmann
force-pushed
the
combined-adjustable-mergeable
branch
from
August 21, 2026 09:27
cfa20ef to
0a72048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
A submission can carry bid adjustment data or block merging data, but not both. The two are signaled independently (
WITH_ADJUSTMENTSflag,merge_type), but no body encoding carries both extensions, and the decoder drops one of the two when both are signaled: the dehydrated mergeable path ignores the with-adjustments flag, and the with-adjustments path errors onmerge_type: mergeable.A builder submitting mergeable blocks therefore loses bid adjustment on those bids entirely.
Solution
Add a combined body encoding — core fields ++
bid_adjustment_data++merging_data— selected by the existing signals (with-adjustments flag set andmerge_type: mergeable), and have the decoder return both extensions. Existing single-extension wire formats are unchanged.The body layout matches the combined submission format already accepted by the ultra sound relay, so builders can use a single encoder for both relays.
Details
SignedBidSubmissionWithAdjustmentsAndMergingDataandDehydratedBidSubmissionFuluWithAdjustmentsAndMergingDatacarrying bothbid_adjustment_dataandmerging_data(core fields ++ bid_adjustment_data ++ merging_data)