feat: add release 0.0.0 version substitution to run configuration and updat…#163
Open
omkargaikwad23 wants to merge 7 commits intomainfrom
Open
feat: add release 0.0.0 version substitution to run configuration and updat…#163omkargaikwad23 wants to merge 7 commits intomainfrom
omkargaikwad23 wants to merge 7 commits intomainfrom
Conversation
…e cloudbuild environment variables
omkargaikwad23
added
autorelease: triggered
omkargaikwad23
changed the title
… branches in cloudbuild.yaml
…I using secret token
… release branches
| # limitations under the License. | ||
|
|
||
| extension_id: cloud-sql-postgresql | ||
| release_version: ${RELEASE_VERSION} |
Contributor
There was a problem hiding this comment.
I think we should use separate yaml file this can be confusing we want to have standard config files across evalbench
Contributor
Author
There was a problem hiding this comment.
I'd prefer to keep these lines in run_config.yaml. The evalbench framework expects a single configuration file via the --experiment_config flag, and these fields are part of that run's specific configuration. Splitting them into a separate file would require us to add an extra step in Cloud Build to merge files together before running, which adds unnecessary complexity.
omkargaikwad23
commented
Apr 24, 2026
Contributor
Author
omkargaikwad23
left a comment
omkargaikwad23
left a comment
There was a problem hiding this comment.
Resolved the comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e cloudbuild environment variables