EntityData.Version not serialized - #113
Draft
Shard wants to merge 2 commits into
Draft
Conversation
|
How import is backwards compatibility? Adding the version field means deserializing files serialized by an earlier version of Arch.Persistence will fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue with de-serialization where all the entities that were re-loaded into the world were failing isAlive checks and breaking code that utilizes it. Looking into it, it seems like the version is being reset and not serialized which then breaks isAlive?
I could be wrong in my approach as i don't understand the library all that well only just getting into ECS, but i thought i would submit the test case and a fix which im not really sure is warranted but seems to fix the test case and ill probably use for my own project for now as it seems to fix the issue for me.