stage4: add missing pre-distkmerge controller case for distkernel builds#34
Open
reavessm wants to merge 1 commit into
Open
stage4: add missing pre-distkmerge controller case for distkernel builds#34reavessm wants to merge 1 commit into
reavessm wants to merge 1 commit into
Conversation
Signed-off-by: Stephen Reaves <reaves735@gmail.com>
Contributor
Author
|
For reference, this was the error I was hitting: 19 Jun 2026 01:21:16 -00: ERROR : CatalystError: cmd(['/usr/share/catalyst/targets/stage4/controller.sh', 'pre-distkmerge']) exited 1
ERROR:catalyst:CatalystError: cmd(['/usr/share/catalyst/targets/stage4/controller.sh', 'pre-distkmerge']) exited 1
19 Jun 2026 01:21:16 -00: ERROR : Exception running action sequence build_kernel
Traceback (most recent call last):
File "/usr/lib/python3.14/site-packages/catalyst/base/stagebase.py", line 38, in run_sequence
func()
~~~~^^
File "/usr/lib/python3.14/site-packages/catalyst/base/stagebase.py", line 1715, in build_kernel
cmd([self.settings['controller_file'], 'pre-distkmerge'], env=self.env)
~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.14/site-packages/catalyst/support.py", line 66, in cmd
raise CatalystError('cmd(%r) exited %s' % (args, ret),
print_traceback=False)
catalyst.support.CatalystError: cmd(['/usr/share/catalyst/targets/stage4/controller.sh', 'pre-distkmerge']) exited 1
ERROR:catalyst:Exception running action sequence build_kernel
Traceback (most recent call last):
File "/usr/lib/python3.14/site-packages/catalyst/base/stagebase.py", line 38, in run_sequence
func()
~~~~^^
File "/usr/lib/python3.14/site-packages/catalyst/base/stagebase.py", line 1715, in build_kernel
cmd([self.settings['controller_file'], 'pre-distkmerge'], env=self.env)
~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.14/site-packages/catalyst/support.py", line 66, in cmd
raise CatalystError('cmd(%r) exited %s' % (args, ret),
print_traceback=False)
catalyst.support.CatalystError: cmd(['/usr/share/catalyst/targets/stage4/controller.sh', 'pre-distkmerge']) exited 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stage4 spec sets
boot/kernel/<name>/distkernel: yes, catalyst'sstagebase.py:build_kernel()callscontroller.sh pre-distkmerge. The stage4 controller had no case for this action, so it fell through to the defaultexit 1, making distkernel stage4 builds impossible.This patch adds the missing
pre-distkmerge)case, wiring up the existingtargets/support/pre-distkmerge.shscript which runsemerge --oneshot sys-kernel/dracutinside the chroot before the distributed kernel package ismerged.